From owner-freebsd-current@FreeBSD.ORG Fri Nov 28 13:29:53 2014 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C38C5734; Fri, 28 Nov 2014 13:29:53 +0000 (UTC) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 55E76A18; Fri, 28 Nov 2014 13:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date; bh=Af6h9AEVkoot56lA0PxwSeZJwCWd4OJzv0SadL7n3TU=; b=dlGCRaIt2zq+CN4eksuDylSjENbdLCskC8+IH8QqOJZ7crPKXMDf33A4Qk2RJjkqupURAmAsQKB7/bqa+qKfG852lqEHJpQ03hlUoi/ECcJUjcmse7QTIrBkFabZb1LZt9awMzHhdKEJx3cHpK+S2ORD8boEzoNjInNyrt9XKVs2ozf6XABz+ldnUx1jU6P+dpyZ98hee/pVDqYltBb2Q4o6MIEVNz/UnAiFqiaQyUI/SSRlR6i0zWK7mulgRB8DHiY8Uc53AyaXHiUbUBaKiT2+Qbl70FJUAogVVHreT/BT/DfcLzjXj8AVqq/5cEe5mltlUzrIwfUVByhsB1c6U8i8Hm2E2hsUOXVZOQLGq8PJq+pnWcqxAEM6BqlwQ5lOWkqc/tYF/gVZeVv0+MwxwR0UeHkRK9hoHTn2ymFcwinseZMZFFbBN/lQ9t9N0WHice7qXPGiPe819d3I/35OQ1c3Cnazuzgq4ZE+6eyqmy8paf/KeQwLakD15C5zQzHjlAPXavcHHMMS9wCcrY+IaiRQ/fGo1ZK7m61v/wC5pjPdyi+V5n1qTLt8zl47gmon2gR5ECiWcj6FChvqBjTRwaSVc/d7lCQqQPi03IsseeOEfemmm6lkXxfZnlcznqDO7FXfFAyXiZA1wsL5LDdu8BSg8UIcBWdlrCvwCRYNlbI=; Received: from void.codelabs.ru (void.codelabs.ru [144.206.233.66]) by 0.mx.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1XuLcG-0004i6-9l; Fri, 28 Nov 2014 17:29:44 +0400 Date: Fri, 28 Nov 2014 16:29:42 +0300 From: Eygene Ryabinkin To: kib@FreeBSD.org Subject: [CFR][PATCH] drm2: don't assume that dev->driver->max_ioctl > *dev->driver->compat_ioctls_nr Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="185D1s7FREAUfc0L" Content-Disposition: inline Sender: rea@codelabs.ru Cc: freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 13:29:53 -0000 --185D1s7FREAUfc0L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Konstantin, *, good day. I noticed that the current ioctl processing code for drm2 implicitely assumes that the number of native ioctls is higher than that of 32-bit compat ones, so it immediately gives EINVAL when nr >=3D dev->driver->max_ioctl. Seems that in future such assumption may not be true in all cases. This can be fixed with the following patch: http://codelabs.ru/fbsd/patches/drm2/drm_drv-untangle-32bit-compat.diff Any thoughts on it? Thanks. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --185D1s7FREAUfc0L Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iL4EABEKAGYFAlR4eMZfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PtkwQD/cF22KnZ/mqgwaQDs1TSrJehP FKGerfR5mxp2X+zN4u4A/iZAnQh/qBG0DezuHdObMKrsuEJYfv2teeo7YJPR1L0F =VLbF -----END PGP SIGNATURE----- --185D1s7FREAUfc0L--