From owner-svn-src-head@freebsd.org  Mon May  7 17:28:18 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA875FB77DB;
 Mon,  7 May 2018 17:28:17 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4516378EA4;
 Mon,  7 May 2018 17:28:16 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w47HSD4X056877;
 Mon, 7 May 2018 10:28:13 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w47HSDuD056876;
 Mon, 7 May 2018 10:28:13 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201805071728.w47HSDuD056876@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r333324 - in head/sys: amd64/amd64 conf
In-Reply-To: <CANCZdfrJUuy5OnYM-+opNmnCoJsx6y=oRLOD41rHyXOfUjS4Rw@mail.gmail.com>
To: Warner Losh <imp@bsdimp.com>
Date: Mon, 7 May 2018 10:28:13 -0700 (PDT)
CC: "Conrad E. Meyer" <cem@freebsd.org>,
 "Rodney W. Grimes" <rgrimes@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 May 2018 17:28:18 -0000

[ Charset UTF-8 unsupported, converting... ]
> On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer <cem@freebsd.org> wrote:
> 
> > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes
> > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> > >> + *  ws@tools.de     (Wolfgang Solfrank, TooLs GmbH) +49-228-985800
> > >
> > > If the original is by ws@tools.de, who is this version by?
> > > Or is this simply copied from some other FreeBSD file?
> >
> > This is covered thoroughly in lines 1-10 of the commit email:
> >
> > > Author: mjg
> > ...
> > >   memmove is repurposed bcopy (arguments swapped, return value added)
> >
> 
> It's also trivial to see from code comparison... It noticed it right away
> while reviewing...

I believe both you and Conrad are placing to much weight on the commit
message and no weight on the comment.  Someone reading the code is not
going to have the context we presently have.

Comments in code need to stand alone, without any context of commit
message creating them, or code else where, unless they directly
reference that code else where.

-- 
Rod Grimes                                                 rgrimes@freebsd.org