From owner-svn-src-all@freebsd.org Fri Aug 17 16:35:31 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4794E1074E91; Fri, 17 Aug 2018 16:35:31 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl0-x235.google.com (mail-pl0-x235.google.com [IPv6:2607:f8b0:400e:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA24B89206; Fri, 17 Aug 2018 16:35:30 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl0-x235.google.com with SMTP id p4-v6so396756pll.8; Fri, 17 Aug 2018 09:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yraYnkRXBB7w2mCKKFDiNRCKZp2xNQVJmHUbSx0jOzM=; b=RzIKYZPeOW8iLAB3usN3JM5ZA+wDd2gk6S88v7P3k5Eb68+3hLqxZzWjup5dIq05Qm 5e72C85/1wU5dQg1JhPUP/pmj2VosCQ+Sg19uIsR9YNNjxq5qDkBPXU1jV9YKdgSHrtN WSq10nZuDBsvUyYsjN6OEh31GkzWYEG1PUPE4htrd40li9LqQeD7eR1dKM7fon3ocQUZ CrGBdBwJpTvmnz+En5bVxDZctnlImzG8TelHMcU9dpKrfwTUhGRpGn3hX1iVXlxD7ZaX +uwLoIrAiyhjX3E8e1SYgTW0PJTbQkOIZT3F0uCxZSsweFzOwIiqIHvtkWjwiGnBvPry jZUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yraYnkRXBB7w2mCKKFDiNRCKZp2xNQVJmHUbSx0jOzM=; b=GPmKd2ZwvmeG97xEhM7KWrc53Kf0vhpQLCWNoQ6+5bqe+Ll1R25mpU2Mlay64tL1sC Ffi76xMJsdOAls7wjs6EK4Uzkz2ZmzVb8TDHn7YejWcRkWMFCcbBiqq2dWdzjrJ5ShkR B1LgGHhaQ/6lWs7CaY0jhn3QaeXf3R3ChNpQV7BApskttbAPGnR4bJcdnPwgPIrxUm+v AOezuRSCpEvEM5m9XbT2NfTxC0ARv7Fj9LwRSmupNWyX5PuZ38D+vb2M9CTkIasshy3N UpPmVLQ5iP3EI768UPimnZ0JQjNueNvQIBt41sPiVn0hgcDV3X9Mqg1dOt+7NWenvkcj LSnQ== X-Gm-Message-State: AOUpUlHmO/OVs66P9GcKRaHcQ1agSkzKDsevwVDtjHYTa1DZI5T9S4Oc FXIg6E1sPikmvYM4lBiF17fip5sb X-Google-Smtp-Source: AA+uWPybKtFpOYpNSY6BCyfsyebapgRLXdyNwxQ9Y5dMdUoEIneBVFhbu+wcvzzwPouszvz5lrJL6w== X-Received: by 2002:a17:902:14e:: with SMTP id 72-v6mr34109816plb.299.1534523729486; Fri, 17 Aug 2018 09:35:29 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id 16-v6sm5180375pfo.164.2018.08.17.09.35.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 09:35:28 -0700 (PDT) Sender: Mark Johnston Date: Fri, 17 Aug 2018 12:35:25 -0400 From: Mark Johnston To: Conrad Meyer Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... Message-ID: <20180817163525.GB13168@raichu> References: <201808170023.w7H0Np0H027296@repo.freebsd.org> <201808170503.w7H53GR9023607@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 16:35:31 -0000 On Fri, Aug 17, 2018 at 09:17:58AM -0700, Conrad Meyer wrote: > On Fri, Aug 17, 2018 at 9:12 AM, Warner Losh wrote: > > > > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer wrote: > >> We don't intend[sic] on tailoring it at all. > > > > We don't document such an exception... history tells me this belief may be > > optimistic.. > > I think it is a generally understood convention re: contrib code. I > called out intent in the commit message for the directory, and anyway > it is generally frowned upon in the project to modify contrib code for > non-abandoned upstreams. E.g., there was quite a bit of resistance > modifying top(1) until it was deemed dead upstream and moved out of > contrib. Rather, I'd say it shouldn't be done gratuitously: every commit to contrib code adds to our cumulative technical debt until it is reconciled with upstream. Sometimes, however, that's the right tradeoff to make (or it's simply necessary for some reason). In that case having a vendor branch is important, and one should be created preemptively even if there is no current intention to modify the imported code.