From owner-cvs-src@FreeBSD.ORG  Sun Jun 17 05:14:55 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1F29616A400;
	Sun, 17 Jun 2007 05:14:55 +0000 (UTC) (envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31])
	by mx1.freebsd.org (Postfix) with ESMTP id D95E913C45B;
	Sun, 17 Jun 2007 05:14:54 +0000 (UTC) (envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1])
	by mail.cs.rice.edu (Postfix) with ESMTP id D6DC42C2AC9;
	Sun, 17 Jun 2007 00:14:53 -0500 (CDT)
X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu
Received: from mail.cs.rice.edu ([127.0.0.1])
	by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new,
	port 10024)
	with LMTP id wZtuLrKsK5ND; Sun, 17 Jun 2007 00:14:46 -0500 (CDT)
Received: from [216.63.78.18] (adsl-216-63-78-18.dsl.hstntx.swbell.net
	[216.63.78.18])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.cs.rice.edu (Postfix) with ESMTP id 039192C2AC7;
	Sun, 17 Jun 2007 00:14:45 -0500 (CDT)
Message-ID: <4674C345.5010207@cs.rice.edu>
Date: Sun, 17 Jun 2007 00:14:45 -0500
From: Alan Cox <alc@cs.rice.edu>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070328
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Matt Jacob <mjacob@FreeBSD.org>
References: <200706170417.l5H4Hn29025615@repoman.freebsd.org>
In-Reply-To: <200706170417.l5H4Hn29025615@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_mmap.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Jun 2007 05:14:55 -0000

Matt Jacob wrote:

>mjacob      2007-06-17 04:17:49 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/vm               vm_mmap.c 
>  Log:
>  Make sure object is NULL- there is a possible case where you could
>  fall through to it being used w/o being set. Put a break in the default
>  case.
>  
>  Revision  Changes    Path
>  1.211     +2 -1      src/sys/vm/vm_mmap.c
>  
>

Actually, no.  handle_type is OBJT_DEFAULT only if flags has MAP_ANON 
set.  So, object was, in fact, being initialized to NULL a few lines 
after the switch:

    if (flags & MAP_ANON) {
        object = NULL;

In any case, I'm happy to see the warnings eliminated.

Regards,
Alan