From owner-freebsd-python@FreeBSD.ORG Mon Nov 29 00:36:35 2010 Return-Path: Delivered-To: freebsd-python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C84BE1065673 for ; Mon, 29 Nov 2010 00:36:35 +0000 (UTC) (envelope-from jhein@gossamer.timing.com) Received: from mout.perfora.net (mout.perfora.net [74.208.4.195]) by mx1.freebsd.org (Postfix) with ESMTP id 90BE08FC1B for ; Mon, 29 Nov 2010 00:36:34 +0000 (UTC) Received: from gossamer.timing.com ([206.168.13.144]) by mrelay.perfora.net (node=mrus3) with ESMTP (Nemesis) id 0Lb5jF-1OhB453k09-00kKUN; Sun, 28 Nov 2010 19:23:58 -0500 Message-ID: <19698.62100.697550.630785@gossamer.timing.com> Date: Sun, 28 Nov 2010 17:23:48 -0700 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8qxSgvgPz6" Content-Transfer-Encoding: 7bit From: John Hein To: bug-followup@FreeBSD.org In-Reply-To: <201011151830.oAFIUFPK047946@freefall.freebsd.org> References: <201011151830.oAFIUFPK047946@freefall.freebsd.org> X-Mailer: VM 8.0.12 under 22.3.1 (i386-redhat-linux-gnu) X-Provags-ID: V02:K0:mlqmWpiarr0I0tAupbngeqj7snuNYGO/vRa573/5SBn hdICjLR1wNFJHLTKaIduYRCzvvBImjJO7GFYb8G1gTMyXWOkZM vDCovsMReUj9s1zvuFHFneHChSPpvpc2SlU/loueneacQBBR72 /SiQvE7Ie6ExxtN5+OEhTkdyBLl8FC3Fga0ewM55N8RbwC8Pmb bMgc9M7XFz+toCUHZfKrQ== Cc: freebsd-python@FreeBSD.org Subject: Re: ports/152224: [patch] fix installed permissions for lang/python27 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2010 00:36:35 -0000 --8qxSgvgPz6 Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit This patch is still needed for python 2.7.1 The 2.7.1 distribution tarball doesn't have 'other' permissions set, so the post-extract is still needed. The second part that uses --no-same-owner with tar in post-install is still needed in general to avoid having the installed files owned by the build user. [As described in the original report, this is needed for at least python26 as well]. --8qxSgvgPz6 Content-Type: text/plain; name="p" Content-Description: fix permissions for lang/python27 Content-Disposition: inline; filename="p" Content-Transfer-Encoding: 7bit Index: Makefile =================================================================== RCS file: /base/FreeBSD-CVS/ports/lang/python27/Makefile,v retrieving revision 1.169 diff -u -p -r1.169 Makefile --- Makefile 6 Sep 2010 00:25:04 -0000 1.169 +++ Makefile 29 Nov 2010 00:15:42 -0000 @@ -146,6 +146,12 @@ CONFIGURE_ARGS+= --disable-ipv6 CONFIGURE_ARGS+= --with-fpectl .endif +post-extract: +# The distribution tarball for python 2.7 has permission bits for 'others' +# set to 0. Later during install, we copy Tools and Demo to the installed +# prefix, so set them right here. + ${CHMOD} og=u-w ${PYTHON_WRKSRC}/Tools ${PYTHON_WRKSRC}/Demo + pre-patch: ${CP} -r ${PATCH_WRKSRC}/Lib/plat-freebsd8 \ ${PATCH_WRKSRC}/Lib/plat-freebsd9 @@ -260,12 +266,12 @@ post-install: .if !defined(NOPORTDATA) @${MKDIR} ${DATADIR} @cd ${PYTHON_WRKSRC}; ${TAR} -cf - Tools | \ - (cd ${DATADIR}; ${TAR} -xf -) + (cd ${DATADIR}; ${TAR} --no-same-owner -xf -) .endif .if !defined(NOPORTEXAMPLES) @${MKDIR} ${EXAMPLESDIR} @cd ${PYTHON_WRKSRC}/Demo; ${TAR} -cf - * | \ - (cd ${EXAMPLESDIR}; ${TAR} -xf -) + (cd ${EXAMPLESDIR}; ${TAR} --no-same-owner -xf -) .endif @${CAT} ${PKGMESSAGE} --8qxSgvgPz6--