Date: Wed, 16 Feb 2005 16:21:27 -0500 From: Coleman Kane <zombyfork@gmail.com> To: obrien@freebsd.org Cc: freebsd-amd64@freebsd.org Subject: Re: [PATCH] Updated quirk-driven R3000Z patches Message-ID: <346a8022050216132169d2fee5@mail.gmail.com> In-Reply-To: <20050216183628.GB83553@dragon.nuxi.com> References: <200502141722.10259.jhb@FreeBSD.org> <20050216134731.GB99724@ramen> <20050216174530.GD82895@dragon.nuxi.com> <200502161256.34505.jkim@niksun.com> <20050216140808.GF99724@ramen> <20050216183628.GB83553@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 16 Feb 2005 10:36:28 -0800, David O'Brien <obrien@freebsd.org> wrote: > [ PLEASE don't top-post, else I may not reply. This is a Unix list. ] > > On Wed, Feb 16, 2005 at 02:08:08PM +0000, Coleman Kane wrote: > > Yeah the recipient of the fix just emailed me about this, I am guessing > > that the #if 0 is the uncommitable part. Is there any way that this can > > be done by the kernel (the PCI reg write, that is)? Is there any reason > > that it can't be done there? > > Yes, the "#if 0" in > http://lists.freebsd.org/mailman/htdig/freebsd-amd64/2005-January/003365.html > isn't commitable. > > > All you need is the second hunk, which is commitable, I believe. The > > > first hunk has to be fixed from BIOS or manually corrected by: > > Jung-uk, can you post another patch with just this fix? In a commitable > form please. > > -- > -- David (obrien@FreeBSD.org) > _______________________________________________ > freebsd-amd64@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-amd64 > To unsubscribe, send any mail to "freebsd-amd64-unsubscribe@freebsd.org" > I have attached the patch with the #if 0 / #endif removed. Can anyone please enlighten me as to why the first hunk would be a 'regression'? -- coleman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?346a8022050216132169d2fee5>