From owner-freebsd-current@FreeBSD.ORG  Tue Jun 20 21:52:38 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 42D0B16A47B;
	Tue, 20 Jun 2006 21:52:38 +0000 (UTC)
	(envelope-from deischen@freebsd.org)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D31F343D83;
	Tue, 20 Jun 2006 21:52:37 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.ntplx.net (8.13.6/8.13.6/NETPLEX) with ESMTP id k5KLqaHr029806; 
	Tue, 20 Jun 2006 17:52:36 -0400 (EDT)
Date: Tue, 20 Jun 2006 17:52:36 -0400 (EDT)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200606201707.05938.jhb@freebsd.org>
Message-ID: <Pine.GSO.4.64.0606201750440.17356@sea.ntplx.net>
References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org>
	<20060620230149.S43840@atlantis.atlantis.dp.ua>
	<200606201707.05938.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
Cc: freebsd-current@freebsd.org
Subject: Re: Linux-flashplugin7 & rtld - RFC
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2006 21:52:38 -0000

On Tue, 20 Jun 2006, John Baldwin wrote:

> On Tuesday 20 June 2006 16:07, Dmitry Pryanishnikov wrote:
>>
>> Hello!
>>
>> On Tue, 20 Jun 2006, John Baldwin wrote:
>>>>> This patch is somewhat redundant.  Adding
>>>>>
>>>>> 	__weak_reference(dlsym, _dlsym);
>>>>>
>>>>> is enough.
>>>>
>>>>   Indeed, this also works for me. It would be nice to see this trivial
>>>> addition committed.
>>>
>>> I agree.  Do you have the __weak_reference() patch handy?
>>
>>   Sure, here is the diff against HEAD:
>>
>> --- libexec/rtld-elf/rtld.c.orig        Tue Mar 28 10:17:21 2006
>> +++ libexec/rtld-elf/rtld.c     Tue Jun 20 22:35:17 2006
>> @@ -137,6 +137,8 @@
>>
>>   void r_debug_state(struct r_debug*, struct link_map*);
>>
>> +__weak_reference(dlsym, _dlsym);
>> +
>>   /*
>>    * Data declarations.
>>    */
>>
>> I'm not sure whether it's style(9)-compliant, it just works.
>
> Well, this patch was shot down.  Would it be possible to have the
> pluginwrapper provide the _dlsym weak reference itself?

I was going to suggest that also.

-- 
DE