From owner-cvs-src@FreeBSD.ORG Sun May 4 08:46:36 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADA1B37B401; Sun, 4 May 2003 08:46:36 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3DEC43F85; Sun, 4 May 2003 08:46:35 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h44Fium2010881; Sun, 4 May 2003 08:45:00 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h44Fip71010880; Sun, 4 May 2003 08:44:51 -0700 (PDT) Date: Sun, 4 May 2003 08:44:51 -0700 From: "David O'Brien" To: Giorgos Keramidas Message-ID: <20030504154451.GA10690@dragon.nuxi.com> References: <20030503212154.GA4826@gothmog.gr> <200305032130.h43LUJ8c022020@grimreaper.grondar.org> <20030503214427.GA5192@gothmog.gr> <20030504011752.GA50067@dragon.nuxi.com> <20030504124353.GA699@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030504124353.GA699@gothmog.gr> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ls extern.h ls.c print.c util.c src/bin/pax ar_io.c ar_subs.c cache.c cpio.c extern.h gen_subs.c getoldopt.c options.c pat_rep.c pax.c pax.h src/bin/ps fmt.c src/bin/rcp rcp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 May 2003 15:46:37 -0000 On Sun, May 04, 2003 at 03:43:53PM +0300, Giorgos Keramidas wrote: > On 2003-05-03 18:17, David O'Brien wrote: > >On Sun, May 04, 2003 at 12:44:27AM +0300, Giorgos Keramidas wrote: > >>: giorgos@gothmog[00:36]/a/freebsd/src/bin/ps$ rm print.o > >>: giorgos@gothmog[00:36]/a/freebsd/src/bin/ps$ make WARNS=0 print.o > >>: cc -O2 -Wall -pipe -DLAZY_PS -c print.c > >>: print.c: In function `started': > >>: print.c:405: warning: `%y' yields only last 2 digits of year > >>: print.c: In function `lstarted': > >>: print.c:422: warning: `%c' yields only last 2 digits of year in some locales on non-BSD systems > >>: > >>: giorgos@gothmog[00:36]/a/freebsd/src/bin/ps$ rm print.o > >>: giorgos@gothmog[00:36]/a/freebsd/src/bin/ps$ make WARNS=1 print.o > >>: cc -O2 -Wall -pipe -DLAZY_PS -Wsystem-headers -Werror -c print.c > >>... > >> The warnings are a result of -Wformat-y2k, which is included in -Wall: > > > > Why doens't WARNS=1 give you "-Wall -Wno-format-y2k" as it is supose to? > > WARNS=1 doesn't include -Wno-format-y2k, if I'm reading bsd.sys.mk correctly: You are correct, sorry. But the meat of it is how are you getting -Wall and not -Wno-format-y2k? > 30: . if ${WARNS} > 1 > 1.8 obrien 31: CFLAGS += -Wall -Wno-format-y2k > 1.4 obrien 32: . endif As you can see, they come paired together. > > Do you have some local settings in /etc/make.conf?? > > Nothing important there. The most relevant local changes shown by > `diff -u /usr/share/examples/etc/make.conf make.conf' are: > > +NO_CPU_CFLAGS= true # Don't add -march= to CFLAGS automatically > +NO_CPU_COPTFLAGS=true # Don't add -march= to COPTFLAGS automatically > ... > -#CFLAGS= -O -pipe > +CFLAGS?= -O -pipe > ... > -#COPTFLAGS= -O -pipe > +COPTFLAGS?= -O -pipe How are you getting -O2 above?