From owner-freebsd-current@FreeBSD.ORG Fri Dec 17 19:48:16 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 966AC106564A; Fri, 17 Dec 2010 19:48:16 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 430C08FC0A; Fri, 17 Dec 2010 19:48:15 +0000 (UTC) Received: by iwn39 with SMTP id 39so1061201iwn.13 for ; Fri, 17 Dec 2010 11:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:received:reply-to :in-reply-to:references:date:message-id:subject:from:to:cc :content-type; bh=McpW5wv78FJtrFW8Bi7ou5meWA1CNR9q/Kyk3q2wrMY=; b=oNxQWC6gNWbunrrpQKsxViQ9lTZdnWTOwZnhVhkv4wT4nGGqARnBApJTc1kTOfy4OE oZ3lCjUjpiAFVbmgDuSyHWnpsVHvI0wgIDXcpk3s75LyMFCG6Hy8t1LgjXJ1oZioSOps C5wqo7TPAznjH06WkGi7Skp7Np5aMp6L6dFlI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=E2dRWNLDSD8FwXSmaU75507yYuiK9kh9QDyXEgEiEUjMLWiBZXwujIUF9TEHvArflG HAMOOKd2fbyOCnUkIKt4Id/KznxTzcCKMo+MWsRS2FDs+CgcXYEU6rM5hw060RxDXW2q 3sEpI8yKXvPRAimpS8elyG3gDnYmjp5A1CYJU= MIME-Version: 1.0 Received: by 10.42.167.193 with SMTP id t1mr1302266icy.106.1292615295335; Fri, 17 Dec 2010 11:48:15 -0800 (PST) Received: by 10.42.6.67 with HTTP; Fri, 17 Dec 2010 11:48:15 -0800 (PST) In-Reply-To: <20101217143222.GA28086@freebsd.org> References: <20101217143222.GA28086@freebsd.org> Date: Fri, 17 Dec 2010 19:48:15 +0000 Message-ID: From: "b. f." To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org, imp@FreeBSD.org Subject: Re: a few OptionalObsoleteFiles.inc improvements X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf1783@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 19:48:16 -0000 On 12/17/10, Alexander Best wrote: > On Tue Dec 14 10, b. f. wrote: >> Alexander Best wrote: ... >> The last part of your patch reverts a change that Warner Losh made in >> r212525 as part of his tbemd project merge. It's possible that this >> change may have been an unintended, but it followed a discussion in >> which Warner rejected a related patch proposed by Garrett Cooper, >> partly because sysinstall is included in build-tools in Makefile.inc1, >> even though some thought that it should not be. In any event, you >> should probably look into that before committing the last part of your >> patch. > > so is csh, but still you can set WITHOUT_TCSH=true and have a world without > (t)csh. I'll be more explicit: Garrett's original patch went a little farther than yours: he also conditionally removed sysinstall (subject to the use of WITHOUT_SYSINSTALL) from build-tools in Makefile.inc1, as is done now under other knobs with sys/modules/aic7xxx/aicasm, share/syscons/scrnmaps, kerberos5/tools, and rescue/rescue. That is primarily what resulted in it being rejected, as no one remembered why it had been added in: http://svn.freebsd.org/viewvc/base?view=revision&revision=71238 Subsequently, Warner agreed that it could in fact be removed: http://lists.freebsd.org/pipermail/freebsd-arch/2010-June/010398.html However, he didn't remove it, and even later effectively disabled the WITHOUT_SYSINSTALL knob. So I'm suggesting that you find out why he changed his mind (it may have been an oversight), and if sysinstall really isn't needed, then not only make the changes that you originally proposed, but also prevent it from being built in the first place during build-tools, like Garrett did. (The same should be done for other parts of that target, too, like the csh bits.) ... > no need to worry i'll commit any changes, since i don't have commit rights. > ;) ...or before asking someone else to commit it. b.