From owner-freebsd-stable@FreeBSD.ORG  Sun Feb  1 09:52:08 2015
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1E65E685
 for <freebsd-stable@freebsd.org>; Sun,  1 Feb 2015 09:52:08 +0000 (UTC)
Received: from alogt.com (alogt.com [69.36.191.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id ED8C7E9E
 for <freebsd-stable@freebsd.org>; Sun,  1 Feb 2015 09:52:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alogt.com;
 s=default; 
 h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Subject:To:From:Date;
 bh=Ek/frZx1emRfhzzSJ1sGfhe4aj2mJ0FCSIDzCMDw3zs=; 
 b=Ke54G9DgwYHcapF3RymgJy7I6EMGI7Us4CRgXw3+4fNDfDS5NdQF1Tpa0YnwDwfGM8ynGbV/ZLsB7rjqIqMjrjymsKApNthBhAr9d2O4BBCD4Ut9/vGEr5aNW2Tda4uRczZX5kVFCkhagfkeR+BXLWiyqZBNrwMuqkyxUYphchM=;
Received: from [114.121.132.55] (port=57989 helo=B85M-HD3-0.alogt.com)
 by sl-508-2.slc.westdc.net with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128)
 (Exim 4.84) (envelope-from <erichsfreebsdlist@alogt.com>)
 id 1YHrCI-001fgW-5t
 for freebsd-stable@freebsd.org; Sun, 01 Feb 2015 02:52:07 -0700
Date: Sun, 1 Feb 2015 17:51:59 +0800
From: Erich Dollansky <erichsfreebsdlist@alogt.com>
To: freebsd-stable@freebsd.org
Subject: top, fixed buffer length in utils.c
Message-ID: <20150201175159.7fa88d16@B85M-HD3-0.alogt.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - sl-508-2.slc.westdc.net
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - alogt.com
X-Get-Message-Sender-Via: sl-508-2.slc.westdc.net: authenticated_id:
 erichsfreebsdlist@alogt.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2015 09:52:08 -0000

Hi,

I came across this here in utils.c which is part of top:


/*
 * How do we know that 16 will suffice?
 * Because the biggest number that we
  will
 * ever convert will be 2^32-1, which
 is 10
 * digits.
*/

char *itoa(val)

register int val;

int can be 64 bits on a amd64 machine. Why is the author of this code
so sure that we will never cross the 32 bit boundary?

Erich