From owner-freebsd-hackers@FreeBSD.ORG Wed May 29 19:25:57 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 84D531AD; Wed, 29 May 2013 19:25:57 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com [IPv6:2607:f8b0:4001:c03::22c]) by mx1.freebsd.org (Postfix) with ESMTP id 512D426B; Wed, 29 May 2013 19:25:57 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id 17so5332927iea.17 for ; Wed, 29 May 2013 12:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=sU3iydEr35wYfZoxeMN6KLznwoSqnFFPY2QDGFYRITQ=; b=uqJi9C+dH3B9KB7hjNxKbRbfYe0QO7mlJlw0rxgzx6+FTORqW+6ODzwQE52NTHGBS2 WorCT3WzwSvxUNBdNRzWxOgSgo++YedMD5Rq+zwOIr29UY12pA7L7aDzcrR4ppydPEPF sZ/KgKKpohxXvTw5TZJjbykWexE5OuC6bFgCNNyKEXtdIylAttGshkQYoapFiZ4+yOcQ XVubWRr6KYZsBme5d7J7OTPPld7B3cgvmfTnQXYAdzBp7SfZa97GVnAeU3pj07qZ9k4i ZJsuLY49lbAtLyI4eWx9qrA5uKPxnkT+wS/iGdK7KEAJcjMj/mSjQuxgglFAH4/BhQEg LZxw== X-Received: by 10.50.72.49 with SMTP id a17mr9931264igv.36.1369855556981; Wed, 29 May 2013 12:25:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.71.101 with HTTP; Wed, 29 May 2013 12:25:26 -0700 (PDT) In-Reply-To: <20130529205711.00000111@unknown> References: <9AD6CC08-8C59-4941-8C1D-54ABE74A162C@bsdimp.com> <20130529205711.00000111@unknown> From: Chris Rees Date: Wed, 29 May 2013 20:25:26 +0100 Message-ID: Subject: Re: Order of canonical upgrade sequence To: Alexander Leidinger Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-hackers@freebsd.org" , Glen Barber X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 May 2013 19:25:57 -0000 On 29 May 2013 19:57, Alexander Leidinger wrote: > On Wed, 29 May 2013 11:53:41 -0600 > Warner Losh wrote: > >> [[ summarizing a conversation in irc ]] >> >> The below fragment doesn't match UPDATING. Since I don't think the >> order matters; and since we've had no reports that UPDATING is wrong; >> and since I think way more people follow updating than the Makefile; >> we should fix the makefile and make the docs match both. > > The order matters, mergemaster first, then delete-old. UPDATING is > correct. At least regarding the order all places should be corrected > which tell to use the reverse order. > >> Warner >> >> On May 29, 2013, at 10:02 AM, Chris Rees wrote: >> >> > Hi all! >> > >> > Back in 2005, when Alexander Leidinger wrote the make delete-old >> > target, he documented the order of upgrade such that it should be >> > run before mergemaster [1]; >> > >> > # 7. `make installworld' >> > # 8. `make delete-old' >> > # 9. `mergemaster' > > This is the wrong order. > >> > I have merged the delete-old section of the Handbook into the >> > upgrading chapter, and independently decided to put mergemaster >> > first, because I thought it would be safer, but checked here before >> > I committed. >> > >> > I think that steps 8 and 9 should be reversed, because of the >> > possibility of an unbootable system being made, when an rc script >> > references an executable that has just been removed for example. > > I agree. > Committed. Thanks! Chris