From nobody Sun Feb 15 18:38:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDZRz11VGz6S42H for ; Sun, 15 Feb 2026 18:38:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDZRz0Mpdz3wtj for ; Sun, 15 Feb 2026 18:38:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771180735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sMbRI2344GeoE6HeYa7DxUmqNDx2K+PobhcFqVcFmCc=; b=OjG9NvmWUwzk4OSohBETVM2m2bhfK0/mWpXlM8nNFsDsdVgEMHEF2NcS4vZFnDHqgtDxCM JCC147PEWu3sJMaNcoPwwqnNLZm+RqkFJL7b1b10ar/ECvVRwV1uJ11+T6pq8PUWlgMUM+ W9dxgOF+I03u5JuwvkxYU9R+O1AODuQbgdfXGey/TITl4DuMvJ+rODXryz9GfTbZMxRUuw ALr/BrcpXrIq4ZnzjdC1/mOGBzN+sUWC0FtSZIu/CLRcScg+TjhZK6zMbHvR8i9jip+EXG MBgYk4aP9uDCw1WjCj2O4utE1AYGMhMqhrb6/BbjJyqWFLuwwAylrItG1K9Axg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771180735; a=rsa-sha256; cv=none; b=cjV8GIs7+1KQGirtzQgZLm1GCFeOIZpxwfCGD+r21UKO0JavC7/fuKTXAIQxRUz/0yLUtv soQMW0oUlVr7rZHUbsrUGzKFcWMSJBlMioOB1bN/x4SzvslfiLGlEg53Z4sTAjups9QEqr eC0WtwaV4ZE85v6SsPRjs4AREo5I8hr9Vzr3QROWtd4cuNbqsgEJwLOdcqD3jay6ptCwcu oPCf2ly6a5Hqv7+DjG0MRuC9Y+UeEMJLdV4jnbsxOZ4ve9ZiAdDPA/186VLWVnchh5eiq2 kmgKk+hYk9igdaisty+TbbNOY5nZT3AyZznApmxTKWiKsstYrZFHy83PhiqL+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771180735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sMbRI2344GeoE6HeYa7DxUmqNDx2K+PobhcFqVcFmCc=; b=IG23FXABKawoDX5dFC4IkAiMh9PA+yVVB4uCIdUKQZ2c++mp5twLOZkscKoaAdLpPXVc+D rOJUCs/2Vsfj/8oI7ZjFZe7kyZwWeeVk4njgTEIeupvogYEqIKuK+hyoO1NzTITP9Fauqr ZW2u5RM69qZY5zCz0ruWfPF3WRicsxinFirERTbF0fxPhrcADnSAulepeRs4VpRFcjoD/k nPGIsuRMwLfOvnEFbWlgyUIgCWI8GTI3LFtWSyYvTfptLrRM3ZCtmthK7aXyOlxPGqJX41 LOZuaL9QIpyLXQipx1ZwUja1SgvJ1oJb/ODaMWbkkVVb6JsAnex9A+DfzuOMOA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fDZRy6Cc1z14rH for ; Sun, 15 Feb 2026 18:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38373 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 15 Feb 2026 18:38:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: 411a566d5652 - main - t_create.sh: use `ATF_TESTS_SH_SED` & remove local mods List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 411a566d565277e47c9644d19a5efa0fe5b00179 Auto-Submitted: auto-generated Date: Sun, 15 Feb 2026 18:38:54 +0000 Message-Id: <699212be.38373.36f73286@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=411a566d565277e47c9644d19a5efa0fe5b00179 commit 411a566d565277e47c9644d19a5efa0fe5b00179 Author: Enji Cooper AuthorDate: 2026-02-15 18:26:52 +0000 Commit: Enji Cooper CommitDate: 2026-02-15 18:36:29 +0000 t_create.sh: use `ATF_TESTS_SH_SED` & remove local mods This particular change replaces all local modifications to the test script like so: - Use `ATF_TESTS_SH_SED_test` with a sed(1) statement in the Makefile, instead of the equivalent local modifications. - Remove the need for expecting the output of newfs_msdos to be empty. There isn't much to gain from deviating from the upstream NetBSD test--it's just another local modification that would need to be carried forward. If it's worth testing this FreeBSD-specific behavior, it should be in a FreeBSD-specific test. This makes moving new modifications to the script easier moving forward. MFC after: 1 week --- contrib/netbsd-tests/sbin/newfs_msdos/t_create.sh | 14 ++------------ sbin/newfs_msdos/tests/Makefile | 2 ++ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/contrib/netbsd-tests/sbin/newfs_msdos/t_create.sh b/contrib/netbsd-tests/sbin/newfs_msdos/t_create.sh index 61ed927b8889..dc431166a469 100755 --- a/contrib/netbsd-tests/sbin/newfs_msdos/t_create.sh +++ b/contrib/netbsd-tests/sbin/newfs_msdos/t_create.sh @@ -31,21 +31,11 @@ validfat32_head() { } validfat32_body() { - if true; then - # FreeBSD - exp_err=empty - fsck=fsck_msdosfs - else - # NetBSD - exp_err=ignore - fsck=fsck_msdos - fi - - atf_check -s eq:0 -o ignore -e $exp_err \ + atf_check -s eq:0 -o ignore -e ignore \ newfs_msdos -b 512 -C 33m -F 32 msdos.img # fsck_msdos/newfs_msdos have been fixed # atf_expect_fail "PR bin/46743" - atf_check -s eq:0 -o not-match:FIXED -e empty $fsck -p msdos.img + atf_check -s eq:0 -o not-match:FIXED -e empty fsck_msdos -p msdos.img atf_expect_pass } diff --git a/sbin/newfs_msdos/tests/Makefile b/sbin/newfs_msdos/tests/Makefile index 3f112c7f4710..47c77d8289de 100644 --- a/sbin/newfs_msdos/tests/Makefile +++ b/sbin/newfs_msdos/tests/Makefile @@ -2,5 +2,7 @@ TESTSRC=${SRCTOP}/contrib/netbsd-tests/sbin/newfs_msdos NETBSD_ATF_TESTS_SH+= create +ATF_TESTS_SH_SED_create= -e 's/fsck_msdos/fsck_msdosfs/' + .include .include