From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Jun  5 15:56:31 2012
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D0AD3106566B;
	Tue,  5 Jun 2012 15:56:31 +0000 (UTC)
	(envelope-from glewis@eyesbeyond.com)
Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DC898FC15;
	Tue,  5 Jun 2012 15:56:31 +0000 (UTC)
Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1])
	by misty.eyesbeyond.com (8.14.5/8.14.5) with ESMTP id q55FuWMA009841;
	Tue, 5 Jun 2012 08:56:32 -0700 (PDT)
	(envelope-from glewis@eyesbeyond.com)
Received: (from glewis@localhost)
	by misty.eyesbeyond.com (8.14.5/8.14.5/Submit) id q55FuWhA009840;
	Tue, 5 Jun 2012 08:56:32 -0700 (PDT)
	(envelope-from glewis@eyesbeyond.com)
X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to
	glewis@eyesbeyond.com using -f
Date: Tue, 5 Jun 2012 08:56:32 -0700
From: Greg Lewis <glewis@eyesbeyond.com>
To: Jens Jahnke <jan0sch@gmx.net>
Message-ID: <20120605155632.GA9796@misty.eyesbeyond.com>
References: <201206032153.q53LrFon077891@freefall.freebsd.org>
	<20120604184821.65cdb089.jan0sch@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120604184821.65cdb089.jan0sch@gmx.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: scheidell@freebsd.org, bug-followup@freebsd.org,
	freebsd-ports-bugs@freebsd.org
Subject: Re: ports/168559: Updated lang/clojure to version 1.4.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2012 15:56:31 -0000

On Mon, Jun 04, 2012 at 06:48:21PM +0200, Jens Jahnke wrote:
> Hi,
> 
> I reworked the patch according to the comments.
> 
> Regards,
> 
> Jens

Thanks Jens!  One final comment below:

> diff -ruN clojure.old/files/clojure-bin.in clojure/files/clojure-bin.in
> --- clojure.old/files/clojure-bin.in	2012-06-04 18:37:17.000000000 +0200
> +++ clojure/files/clojure-bin.in	2012-06-04 18:40:02.000000000 +0200
> @@ -2,4 +2,4 @@
>  #
>  # $FreeBSD: ports/lang/clojure/files/clojure-bin.in,v 1.8 2011/07/21 05:02:48 linimon Exp $
>  
> -JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-1.2.0.jar:%%JAVAJARDIR%%/clojure-contrib-1.2.0.jar:%%JAVAJARDIR%%/swank-clojure-1.2.1.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@"
> +JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-${PORTVERSION}.jar:%%JAVAJARDIR%%/swank-clojure-1.4.2.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@"

Here it should be %%PORTVERSION%% since ${PORTVERSION} won't be defined.
When the port is installed the ports infrastructure will take care of
expanding %%PORTVERSION%% to the correct value.

-- 
Greg Lewis                          Email   : glewis@eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis@FreeBSD.org