From owner-dev-commits-src-main@freebsd.org Mon Feb 1 09:39:33 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 35E8D4F8926; Mon, 1 Feb 2021 09:39:33 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DTjZs0tnVz51jl; Mon, 1 Feb 2021 09:39:32 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ej1-f48.google.com with SMTP id p20so3936969ejb.6; Mon, 01 Feb 2021 01:39:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qDgIXXlXn/ZsMLGnpHxLL5Mf5Ks35K5i0ppD9ym/oTE=; b=ThKALNjVUEBYE+ZuguiPxzTRQLKWsisH1zsbtaGTqtEgi0hk2lwt/tnXBgzcNt93sP tyaSiysySe4k5Wpn+nUw8CkTgVDIOa++5R8ALM1pXLO0c50W02YjvYtIO1BrCSr5Zn6/ r3Gs3NkJiXeKfYevpJ7oQl+OXXZxqlGRZLkmlKSL+uoB8pSZGYpL9u/5gQ7IRP3XdzPw kS1dIMCCyuRENmMp0BHCQteDdFWd7na+PW7Xa+/uBdE2ddavXdUeKRPiZSDER8WGM/uh 0h21beqx/LLaWV2O/5ygzPL1SvYVDSdNFNfVM/FkM9ajv9Vyy3jLkcCMmI8jueOgZtCD aU9w== X-Gm-Message-State: AOAM5320DkQNSEKpezl1XLwX0TvL8yiw8dXrzyvL9waE187DNhRyrohk 4Og2kmQ0k0GwNtbTt6kTgSJfBGmaYxPXlw== X-Google-Smtp-Source: ABdhPJzftq0SHA+c1pVCC2EynF5dr8756F7fQzpA9FeDIKam9r12P0JlNEDcb4cu9hiio14kqSCgSg== X-Received: by 2002:a17:907:20aa:: with SMTP id pw10mr16835664ejb.314.1612172371572; Mon, 01 Feb 2021 01:39:31 -0800 (PST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com. [209.85.128.54]) by smtp.gmail.com with ESMTPSA id s18sm8599305edw.66.2021.02.01.01.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Feb 2021 01:39:31 -0800 (PST) Received: by mail-wm1-f54.google.com with SMTP id j18so12005195wmi.3; Mon, 01 Feb 2021 01:39:30 -0800 (PST) X-Received: by 2002:a05:600c:201:: with SMTP id 1mr14016391wmi.104.1612172370699; Mon, 01 Feb 2021 01:39:30 -0800 (PST) MIME-Version: 1.0 References: <202101071105.107B5tUX011254@gitrepo.freebsd.org> <20210110121242.1d9809ff@coosemans.org> In-Reply-To: From: Alexander Richardson Date: Mon, 1 Feb 2021 09:39:19 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7fa2f2a62f04 - main - Rename NO_WERROR -> MK_WERROR=no To: Antoine Brodin Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?Q?T=C4=B3l_Coosemans?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4DTjZs0tnVz51jl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 09:39:33 -0000 On Sun, 31 Jan 2021 at 19:12, Antoine Brodin wrote: > > On Sun, Jan 10, 2021 at 12:12 PM T=C4=B3l Coosemans = wrote: > > > > On Thu, 7 Jan 2021 11:05:55 GMT Alex Richardson > > wrote: > > > The branch main has been updated by arichardson: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D7fa2f2a62f04f095e1e27a= d55aa22a8f59b1df8f > > > > > > commit 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f > > > Author: Alex Richardson > > > AuthorDate: 2021-01-06 17:55:06 +0000 > > > Commit: Alex Richardson > > > CommitDate: 2021-01-07 09:31:03 +0000 > > > > > > Rename NO_WERROR -> MK_WERROR=3Dno > > > > > > As suggested in D27598. This also supports MK_WERROR.clang=3Dno a= nd > > > MK_WERROR.gcc=3Dno to support the existing NO_WERROR. u= ses. > > > > > > Reviewed By: brooks > > > Differential Revision: https://reviews.freebsd.org/D27601 > > > --- > > > diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk > > > index d0e7f1cb00ba..88c73cc6bfe4 100644 > > > --- a/share/mk/bsd.opts.mk > > > +++ b/share/mk/bsd.opts.mk > > > @@ -65,7 +65,8 @@ __DEFAULT_YES_OPTIONS =3D \ > > > SSP \ > > > TESTS \ > > > TOOLCHAIN \ > > > - WARNS > > > + WARNS \ > > > + WERROR > > > > > > __DEFAULT_NO_OPTIONS =3D \ > > > BIND_NOW \ > > > @@ -103,7 +104,8 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > > > INSTALLLIB \ > > > MAN \ > > > PROFILE \ > > > - WARNS > > > + WARNS \ > > > + WERROR > > > .if defined(NO_${var}) > > > .error "NO_${var} is defined, but deprecated. Please use MK_${var}= =3Dno instead." > > > MK_${var}:=3Dno > > > > NO_WERROR is also used by some ports [1] (which have to build against > > multiple version of FreeBSD) and this turns it into an error. Can you > > remove this change or turn it into a warning maybe? Changes to share/m= k > > should always go through a ports exp-run IMHO. > > Ping Alex Richardson? > > Antoine (with hat: portmgr) Hi Antoine, I submitted https://reviews.freebsd.org/D28084 to change this error to a .i= nfo. However, T=C4=B3l said that there weren't many affected ports so this change should not be needed. I can commit this workaround, but if I do this just postpones the problem to when we want to remove the workaround (and might mean it will never be removed). Maybe those ports should just be built with a lower WARNS? Thanks, Alex