From owner-p4-projects@FreeBSD.ORG  Fri May 20 14:48:05 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F034616A4D0; Fri, 20 May 2005 14:48:04 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8645D16A4CE; Fri, 20 May 2005 14:48:04 +0000 (GMT)
Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B5B2143D5E; Fri, 20 May 2005 14:48:03 +0000 (GMT)
	(envelope-from trhodes@FreeBSD.org)
Received: from mobile.pittgoth.com (ip68-230-188-82.dc.dc.cox.net
	[68.230.188.82])	(authenticated bits=0)
	by pittgoth.com (8.13.3/8.13.3) with ESMTP id j4KEm2rw042544
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Fri, 20 May 2005 10:48:03 -0400 (EDT)
	(envelope-from trhodes@FreeBSD.org)
Date: Fri, 20 May 2005 10:47:01 -0400
From: Tom Rhodes <trhodes@FreeBSD.org>
To: "Christian S.J. Peron" <csjp@FreeBSD.org>
Message-ID: <20050520104701.7658a5d5@mobile.pittgoth.com>
In-Reply-To: <200505200017.j4K0HmZP080639@repoman.freebsd.org>
References: <200505200017.j4K0HmZP080639@repoman.freebsd.org>
X-Mailer: Sylpheed-Claws 1.0.1 (GTK+ 1.2.10; i386-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 77201 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2005 14:48:05 -0000

On Fri, 20 May 2005 00:17:48 GMT
"Christian S.J. Peron" <csjp@freebsd.org> wrote:

> http://perforce.freebsd.org/chv.cgi?CH=77201
> 
> Change 77201 by csjp@csjp_xor on 2005/05/20 00:17:30
> 
> 	
> 	-replace a size_t for int in the checksum calculation routines
> 	-declare temp variable to stuff the size of the extended attribute in.
> 	 We have to do this because for some reason the data type representing
> 	 extended attribute size between vn_extattr_get and VOP_GETEXTATTR conflict.
> 	 This makes the mac_chkexec build happy on AMD64

Requested by:	trhodes

Thanks!!!

[SNIP]

>  		return (error);
> +	/* XXX why are'nt extended attribute size specification types between
> +	 * VOP_GETEXTATTR and vn_extattr_get the same?
> +	 */
> +	alen = ealen;
>  	depends = malloc(alen + 1, M_CHKEXEC, M_WAITOK | M_ZERO);
>  	error = vn_extattr_get(vp, IO_NODELOCKED, MAC_CHKEXEC_ATTRN,
>  	    MAC_CHKEXEC_DEP, &alen, depends, curthread);
> 

Good question.

-- 
Tom Rhodes