From owner-freebsd-net Mon Aug 19 11:50:52 2002 Delivered-To: freebsd-net@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 2A70937B400; Mon, 19 Aug 2002 11:50:49 -0700 (PDT) Date: Mon, 19 Aug 2002 11:50:49 -0700 From: Juli Mallett To: Hajimu UMEMOTO Cc: net@FreeBSD.org Subject: Re: log_in_vain does not format IPv6 addrs properly for how they are used... Message-ID: <20020819115048.A47313@FreeBSD.org> References: <20020819112408.A45895@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from ume@mahoroba.org on Tue, Aug 20, 2002 at 03:41:41AM +0900 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org * De: Hajimu UMEMOTO [ Data: 2002-08-19 ] [ Subjecte: Re: log_in_vain does not format IPv6 addrs properly for how they are used... ] > Hi, > > >>>>> On Mon, 19 Aug 2002 11:24:08 -0700 > >>>>> Juli Mallett said: > > jmallett> See patch: http://people.freebsd.org/~jmallett/bracket-ipv6-tcp.diff > > jmallett> When doing log_in_vain, IPv6 addrs are listed, colon seperated with a port, > jmallett> but not enclosed in brackets. > > Yes. But, it doesn't use short form of IPv6 printable format, here. > So, you can simply distinguish port number from IPv6 address. :-) Yeah, but it's still tough for readability, all those [0-9A-F:]+ > jmallett> This encloses them properly for TCP6, and I > jmallett> could do a similar diff for UDP6, if such code should/can be touched in this > jmallett> regard, further diverging from KAME. > > Thank you for asking it. This patch is to tcp_input.c. tcp_input.c > is FreeBSD specific part in KAME repo, and your change is specific to > FreeBSD. So, your change doesn't affect merging KAME. Please go > ahead. Okay, thanks. What about with a change to netinet6/udp6_usrreq.c to simply log() with brackets, like: - "Connection attempt to UDP %s:%d from %s:%d\n", + "Connection attempt to UDP [%s]:%d from [%s]:%d\n", If that's an OK change to make, too, then I will commit these changes. Thanks very much, juli. -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message