From owner-cvs-src@FreeBSD.ORG  Tue Nov 30 19:41:04 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D790616A4CE; Tue, 30 Nov 2004 19:41:04 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 39D4043D1D; Tue, 30 Nov 2004 19:41:04 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iAUJexIf054143;
	Tue, 30 Nov 2004 20:41:00 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Ruslan Ermilov <ru@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 30 Nov 2004 21:23:16 +0200."
             <20041130192316.GB3845@ip.net.ua> 
Date: Tue, 30 Nov 2004 20:40:59 +0100
Message-ID: <54142.1101843659@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@freebsd.org
cc: Doug Barton <DougB@dougbarton.net>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c
	src/sbin/mount_std mount_std.8 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2004 19:41:05 -0000

In message <20041130192316.GB3845@ip.net.ua>, Ruslan Ermilov writes:

>> The reason I did not remove MNT_NODEV but only #defined it to zero was
>> to make it silently ignored.
>> 
>To make it silently ignored, you should have left it with its old value.
>Most operations with MNT_* constants are "bitwise AND", and so zero was
>not a good choice.

I tried to find my copy of "Bitmaps for dummies" to check what
you're saying but I can't find it right now, still, I'm very sure
that you are wrong, I just don't have the book to prove it.

Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.