From nobody Mon Dec 1 20:43:14 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dKwpW0KQXz6KKVS for ; Mon, 01 Dec 2025 20:43:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dKwpV4fNDz4NkD for ; Mon, 01 Dec 2025 20:43:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764621794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=49+oY1BB3ye+kGXn2tJqZ7sUrbvqXaR+6+xAhrNjF6g=; b=M7dSTCFraejPlafHsEQToNF9SxCXTG95P6iKJIcJM4/FynqiAoxQyWDbBLlEr9OzRBoTh5 3k+uybyoKeMx19TLdqSCp1TxjUXwEuTXHTrv4KbgHYlnP0yZdK5d1jM9wK0qZoTI3fh33c d0bGSpVAq3BUcmd5od7b1W2vaAwEb/dNeIsFg7FfngRDuUM27UoYydyC3kgJZRHGAjFgEJ q26DPInt528Vw2Z0Ep+IiEvyLOV+5EdURVrHHKiONTcwxxwUb0nLLaAgSJ1r4m+GflpaMY QYYD+C7feRFm//53rf2B3jFXwPWjVSDtUJHfRYLrxiGSXc/YEdyLcorEEA/4EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764621794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=49+oY1BB3ye+kGXn2tJqZ7sUrbvqXaR+6+xAhrNjF6g=; b=F+e00fIg3fLst4n7lsDiJ71s98jn2tgqTR7PIcvPnO7CPqzmQAg+Vhd1bzCLaDRupF+uu/ rz6TaJFgbxMFzMFytl7sTQoLcD2+iB2mrfXS1Il2fB37gQWhWlSTOZjwJiMzcgZNyB4BPO S+jzilIahsYpQX3sRoRQ8nWa2H6GZMPrLNS8iZcc5jiV+gs3ubqQCI004av+2rfaU+Mudh Z4u6I2HyAwFRGf1MF5/m6rg0hoq9S4Om9NJLuxgGbzgSr1vZZj3bKtHdoSSINVNbARZPgk neG6AZzWCllChY9ZA1ELohKIJeirPMbYClspacm9rnksaPQGNjy4hvjI8Q+UDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764621794; a=rsa-sha256; cv=none; b=a8OC3FsSnCOUGJX2GeKwuks8XEdY4ufbaD5o+OCBjEUbmvW47xHiVZv47j1rDAOdDts6V9 KrPyBWGqo+GzLJEZXwHpFHYrIket+p9MisEMj1pliHgQfpQWPZ3WbGOeIQtIXtPJwFKsQv MGeSqgBIt99II0B+b69CnYKgUV00JUQ49TRQvr0dVMNO8GfFkLQEBtUq7n2Vks+IOKash4 D5jkI8TB1NUznHPEJ4RlXxH5LL15oiVR64Kq//wXQd3u/aBHHgCl/ZGJKGCCPYdZqT+IVp D3ejFG8R4Ghp6zUipg7S9E1lGKAP9h3+7zg1OEKfH5ASu7VpdVJ0aOrQsuLlhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dKwpV40qdzdQh for ; Mon, 01 Dec 2025 20:43:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 305b9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 01 Dec 2025 20:43:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Robert Wahlberg From: Vladimir Kondratyev Subject: git: e3201cec8381 - main - psm: Fix three finger tap on elantech v4 touchpads List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e3201cec8381c0582374f93991eff4a71bb95e9b Auto-Submitted: auto-generated Date: Mon, 01 Dec 2025 20:43:14 +0000 Message-Id: <692dfde2.305b9.6c8cabfe@gitrepo.freebsd.org> The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=e3201cec8381c0582374f93991eff4a71bb95e9b commit e3201cec8381c0582374f93991eff4a71bb95e9b Author: Robert Wahlberg AuthorDate: 2025-12-01 20:42:15 +0000 Commit: Vladimir Kondratyev CommitDate: 2025-12-01 20:42:15 +0000 psm: Fix three finger tap on elantech v4 touchpads Fix an issue where a three finger tap would generate additional events when fingers moved slightly during the tap. Signed-off-by: Robert Wahlberg Pull Request: https://github.com/freebsd/freebsd-src/pull/1792 Reviewed by: wulf MFC after: 1 month --- sys/dev/atkbdc/psm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/dev/atkbdc/psm.c b/sys/dev/atkbdc/psm.c index 137758b104d3..d36396df0fa0 100644 --- a/sys/dev/atkbdc/psm.c +++ b/sys/dev/atkbdc/psm.c @@ -4666,6 +4666,13 @@ proc_elantech(struct psm_softc *sc, packetbuf_t *pb, mousestatus_t *ms, mask = sc->elanaction.mask; nfingers = bitcount(mask); + /* The motion packet can only update two fingers at a time. + * Copy the previous state to get all active fingers. */ + for (id = 0; id < ELANTECH_MAX_FINGERS; id++) + if (sc->elanaction.mask & (1 << id)) + f[id] = sc->elanaction.fingers[id]; + + /* Update finger positions from the new packet */ scale = (pb->ipacket[0] & 0x10) ? 5 : 1; for (i = 0; i <= 3; i += 3) { id = ((pb->ipacket[i] & 0xe0) >> 5) - 1;