Date: Tue, 27 Aug 2013 22:54:27 +0200 From: Andre Oppermann <andre@freebsd.org> To: Thomas Skibo <ThomasSkibo@sbcglobal.net> Cc: freebsd-arm <freebsd-arm@FreeBSD.org> Subject: Re: ARM network trouble after recent mbuf changes Message-ID: <521D1203.6070506@freebsd.org> In-Reply-To: <521CDD03.1010108@sbcglobal.net> References: <1377550636.1111.156.camel@revolution.hippie.lan> <521BC472.7040804@freebsd.org> <521BD531.4090104@sbcglobal.net> <521C4CD9.4050308@freebsd.org> <0E0536B2-2B7F-4EED-9EFD-4B9E2C2D729A@freebsd.org> <521C87FF.8010100@freebsd.org> <521CDD03.1010108@sbcglobal.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27.08.2013 19:08, Thomas Skibo wrote: > > > On 8/27/13 4:05 AM, Andre Oppermann wrote: >> >> Thanks. I've changed the test accordingly. >> >> While doing the CTASSERTs to prevent such an incident in the future I >> stumbled >> across a bit of evil name space pollution in mbuf.h. It is impossible >> to take >> sizeof(struct m_ext) because "m_ext" is redefined to point into struct >> mbuf. >> >> In addition to the alignment fix I've solved the namespace issues with >> m_ext >> and the stupidly named struct pkthdr as well and properly prefixed >> them. The >> fallout from LINT was zero (as it should be). >> >> http://people.freebsd.org/~andre/m_hdr-alignment-20130827.diff >> >> Please test. >> > > I'm running this patch on Zedboard and it is doing well. Thanks! Fix is in with r254973 (sans the structure renamings to avoid name space clashes). Sorry for the trouble and thanks for your help with debugging and testing. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?521D1203.6070506>