From nobody Mon Jun 24 22:07:56 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7MXr3wFgz5Pmd3 for ; Mon, 24 Jun 2024 22:08:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7MXq6XJ4z4Cp8 for ; Mon, 24 Jun 2024 22:08:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-63bd10df78dso45346237b3.2 for ; Mon, 24 Jun 2024 15:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1719266890; x=1719871690; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2rtIzvvHIHByEHkdwOssBkUBmPFzbM/rgfNbRmtfQmw=; b=b/8CrT1y4/QYZJa6Ln9Wk/xpCaH0pC3gJjoGRH1mcWYhr0Iqh7Mpr4e15TTgVGlkp1 e+7ulJG9t+AsueoQWtd/NHO2CzHuA8REvnrPvs5mdMQsxcT0TyUNVxPtccCM72wBhjt9 O0scofkAagWtFXGjg6b+m0XgnyK8la5hGvGweWL1loMS1tADDSrflTYPZcpi6dyF2mu/ cymngKnxwrEcCyXp+UQAQy25b9s9JHN6aiBxXuR3PcdcTr3TTtV9OfOTmxAAitDQQIvQ vBMWO18gw9SKd2j7YgQ9C+rJU7lgBP9/zC8DXGirXKatNsYm5ie6toacSucpljA2JLn/ ICXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719266890; x=1719871690; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2rtIzvvHIHByEHkdwOssBkUBmPFzbM/rgfNbRmtfQmw=; b=WrX6l5NwlRi2DJL9xmcckpFXtAvV3OBNAlqj8/CZpddJM2GoXdZwYnP+HY8gJqRDcD WuRcyMD2LFk18YyEO59LzLHugsndZbhwWn6UbbKSq7SGr/ehAqphLsp/AtZKruUAu9Vt T/KZVzLM5MLJstVMh8wFEhVDHELGH0pkoSS84+R+WpWLYZiffLTUIgnfATfoDnXs1oH7 2hndfRdqXiiJCnvZeD/g0V9d0QXD3/XD6IA9/Kyh2KuZCXhODXNE9NUJzgJ9QvRgnpZG TziMLGl6WVCSTS0yj9YfNWFq84kfQ/sdwGuS2uM8U8O7R7vMl48YiF9/iyNYb5b9HpUJ 7iJw== X-Forwarded-Encrypted: i=1; AJvYcCU8Lbouk8iZ1WlVVc3tnYBPgd4JLZa5x593j3WjwHJOOQl9KwG/VPo8lP7iYsOJHtbh/9c6W0QvdWXFLp1yNCV/qGpB84VHD0ICta8seHIx X-Gm-Message-State: AOJu0YyxWkfEntXpoIU0gg3CWN83SiB19HnjGNONqz/ADmsrHudfZlmA 1JRpZ68g7qfrMm1CUAH3V3Bzujc/Ggno7p/5u16ILAvXMEM9L2zOTVqsti5IGrYzUHHoEIm0U4Y Dmys7AVLD19s80Uzm1f7miGysTC1zIO9Rjt+5n8NEONTuDFHC X-Google-Smtp-Source: AGHT+IGmMwKbFNaN2LD8opf/YxPWkfN4CEjLFo7twUxcWlsnxD1B3d+FHC31fjnYCNY46C8SRJ0gWACU3Ij6q39OyjY= X-Received: by 2002:a0d:e447:0:b0:644:2639:8645 with SMTP id 00721157ae682-6442639865fmr41663837b3.26.1719266890662; Mon, 24 Jun 2024 15:08:10 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202405032032.443KWhf0045034@gitrepo.freebsd.org> <20240624161128.33c0f518@ralga.knownspace> In-Reply-To: From: Warner Losh Date: Mon, 24 Jun 2024 16:07:56 -0600 Message-ID: Subject: Re: git: c2e9c5bbf022 - main - tpm: Refactor TIS and add a SPI attachment To: Gleb Smirnoff Cc: Justin Hibbits , Warner Losh , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000004ae26a061baa041a" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4W7MXq6XJ4z4Cp8 --0000000000004ae26a061baa041a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 24, 2024, 3:16=E2=80=AFPM Gleb Smirnoff w= rote: > On Mon, Jun 24, 2024 at 04:11:28PM -0400, Justin Hibbits wrote: > J> > sorry for late notice, but we just discovered that after this commit > J> > tpm(4) on ACPI no longer attaches. From what I see ther probe metho= d > J> > isn't even called. > J> > J> Hi Gleb, > J> > J> That's very odd. The probe method hasn't changed, nor has the tpm_acp= i > J> attachment (still acpi), so I'm really confused why it wouldn't be > J> called now. Is there any debugging you can do to further narrow it > J> down? I haven't seen any issues reported internally at Juniper on x86 > J> hardware. I just verified everything should get built properly. > > I started adding printfs to the probe method and as said - it is not > even called. So I puzzled on where to start the debugging. I can test > patches/ideas if you have any. > > Warner is also looking into this problem. > I'm looking at name mismatched and/or moved parents to see if that's in play. I thought I'd found something like this earlier, but it was a false alarm I think. Warner > --0000000000004ae26a061baa041a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jun 24, 2024, 3:16=E2=80=AFPM Gleb Smirnoff &l= t;glebius@freebsd.org> wrote:=
On Mon, Jun 24, 2024 at 04:11:28PM= -0400, Justin Hibbits wrote:
J> > sorry for late notice, but we just discovered that after this co= mmit
J> > tpm(4) on ACPI no longer attaches.=C2=A0 From what I see ther pr= obe method
J> > isn't even called.
J>
J> Hi Gleb,
J>
J> That's very odd.=C2=A0 The probe method hasn't changed, nor h= as the tpm_acpi
J> attachment (still acpi), so I'm really confused why it wouldn'= ;t be
J> called now.=C2=A0 Is there any debugging you can do to further narrow= it
J> down?=C2=A0 I haven't seen any issues reported internally at Juni= per on x86
J> hardware.=C2=A0 I just verified everything should get built properly.=

I started adding printfs to the probe method and as said - it is not
even called. So I puzzled on where to start the debugging. I can test
patches/ideas if you have any.

Warner is also looking into this problem.

I'm looking at name mismatched= and/or moved parents to see if that's in play. I thought I'd found= something like this earlier, but it was a false alarm I think.

Warner
--0000000000004ae26a061baa041a--