From owner-svn-ports-head@FreeBSD.ORG Fri Aug 29 20:09:23 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA0098D6 for ; Fri, 29 Aug 2014 20:09:23 +0000 (UTC) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4000C1F87 for ; Fri, 29 Aug 2014 20:09:22 +0000 (UTC) Received: by mail-lb0-f173.google.com with SMTP id c11so3193189lbj.32 for ; Fri, 29 Aug 2014 13:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=pUeqagPFlIK9l411VFdIXPM12HJObivYa0xP3urpv5Y=; b=VvnxCZnT8hqT2HXqXzgMzZl1Eda2zNPRtszvx+JpoTtp6FWcWqYn93QfkQjAQ+DGDz NSVU2tOOYHSff66+cTl/oVtl9cwPB9Jj+L9V28VRZl9esAyX7R2UY/1mqshDEUxOOycj X4wNav+xIxBT0643o095lPHNlL6mitvPJCdigUkZFOPtpzvPA1X/hZkMWLULV9gJRt2D XccA5Q1fo1rL6QiXnnktWE3LRG3QccSCT8wRvhAPx81a2uHI7j4vNYavmH2Km0h6OgBC qBrQA5eGh+oq7raCSPl5PZjGd1jU6HufxSsehkA42H1dyOZyRbJSscIFrb/b17gab7q6 BmhA== X-Gm-Message-State: ALoCoQkiG+hgk0k+bEuKgByXVZRFHcqcT3L9C84VpDoiDYcerWOIuI9Y2en9wWtx1dEqTQP8w3yl X-Received: by 10.112.48.103 with SMTP id k7mr13037638lbn.32.1409342955122; Fri, 29 Aug 2014 13:09:15 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.171.40 with HTTP; Fri, 29 Aug 2014 13:08:54 -0700 (PDT) In-Reply-To: <20140829184115.GL42528@f10.opsec.eu> References: <201408281407.s7SE77sA063958@svn.freebsd.org> <20140829184115.GL42528@f10.opsec.eu> From: Sunpoet Po-Chuan Hsieh Date: Sat, 30 Aug 2014 04:08:54 +0800 X-Google-Sender-Auth: tzOSm4CiXaHCCQgTm3310fBmuHY Message-ID: Subject: Re: svn commit: r366405 - in head/databases: . p5-Net-Async-CassandraCQL To: Kurt Jaeger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Andrej Zverev , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 20:09:23 -0000 On Sat, Aug 30, 2014 at 2:41 AM, Kurt Jaeger wrote: > Hi! > > > In real life, modules from Test:: namespace usually requires only for > > tests. No issue for people who using binary packages, but extra deps for > > people who still using ports. > > > http://cpansearch.perl.org/src/PEVANS/Net-Async-CassandraCQL-0.11/Build.PL > > If I build it in poudriere with the p5-Test-* ports as TEST_DEPENDS > instead of BUILD_DEPENDS, the message during build is: > > [...] > Checking prerequisites... > build_requires: > ! Test::Identity is not installed > ! Test::Refcount is not installed > > ERRORS/WARNINGS FOUND IN PREREQUISITES. You may wish to install the > versions > of the modules indicated above before proceeding with this installation. > [...] > > See > > > http://people.freebsd.org/~pi/logs/databases__p5-Net-Async-CassandraCQL-10a-1409337481.txt > > http://people.freebsd.org/~pi/logs/databases__p5-Net-Async-CassandraCQL-91a-1409337481.txt > > http://people.freebsd.org/~pi/logs/databases__p5-Net-Async-CassandraCQL-84i-1409337481.txt > > So I assume BUILD_DEPENDS is correct. Do you see other options > on how to handle this ? > > -- > pi@FreeBSD.org +49 171 3101372 6 years to go ! > > Hi, TEST_DEPENDS is correct. The author should use "test_requires" instead of "build_requires" in this case. The following results show that Test::{Identity,Refcount} are only for test purpose and not required for runtime. % grep -r Test::Identity * Build.PL: 'Test::Identity' => 0, META.json: "Test::Identity" : "0", META.yml: Test::Identity: '0' t/25clustering-prefer-dc.t:use Test::Identity; t/21prepare.t:use Test::Identity; t/22clustering.t:use Test::Identity; t/20connect.t:use Test::Identity; t/23clustering-primaries.t:use Test::Identity; t/24clustering-events.t:use Test::Identity; % grep -r Test::Refcount * Build.PL: 'Test::Refcount' => 0, META.json: "Test::Refcount" : "0" META.yml: Test::Refcount: '0' t/25clustering-prefer-dc.t:use Test::Refcount; t/21prepare.t:use Test::Refcount; t/22clustering.t:use Test::Refcount; t/23clustering-primaries.t:use Test::Refcount; t/24clustering-events.t:use Test::Refcount; For p5-* ports, please make sure the modules listed in Build.PL or Makefile.PL are truly required. At least a simply "grep" would help to determine if TEST_DEPENDS is more suitable, especially for Test::* dependencies. BTW, there are something can be improved in the Makefile: - MASTER_SITE_SUBDIR is unnecessary. - Please respect minimal version requirement in Build.PL / Makefile.PL, e.g. Future: '0.17' IO::Async::Loop: '0.54' IO::Async::Stream: '0.59' Protocol::CassandraCQL: '0.11' - "devel/p5-Devel-GlobalDestruction>0:${PORTSDIR}/devel/p5-Devel-GlobalDestruction" is incorrect Regards, sunpoet