From owner-cvs-all Tue Mar 27 5:15:10 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 4CE0937B71A; Tue, 27 Mar 2001 05:15:01 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f2RDE4I59818; Tue, 27 Mar 2001 16:14:04 +0300 (EEST) (envelope-from ru) Date: Tue, 27 Mar 2001 16:14:04 +0300 From: Ruslan Ermilov To: Brian Somers Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kmod.mk Message-ID: <20010327161404.D56258@sunbay.com> Mail-Followup-To: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200103271218.f2RCI2U51969@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103271218.f2RCI2U51969@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Tue, Mar 27, 2001 at 01:18:02PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Mar 27, 2001 at 01:18:02PM +0100, Brian Somers wrote: > > * Ruslan Ermilov [010327 03:55] wrote: > > > On Tue, Mar 27, 2001 at 03:50:45AM -0800, Ruslan Ermilov wrote: > > > > ru 2001/03/27 03:50:45 PST > > > > > > > > Modified files: > > > > sys/conf kmod.mk > > > > Log: > > > > Reflect recent bsd.man.mk changes here, but do not assign the > > > > default MAN=${KMOD}.4 value for now. This feature was broken > > > > before, and enabling it now would cause 92 Makefiles to fail. > > > > > > > > Revision Changes Path > > > > 1.100 +9 -6 src/sys/conf/kmod.mk > > > > > > > Should I fix all these 92 Makefiles (they do not have NOMAN=) and > > > enable this feature, or should I drop the bsd.man.mk support from > > > kmod.mk completely? No module installs manpages for now. > > > > How about inverting the logic? meaning they must have a MAN= if > > they want pages installed? > > I believe both NetBSD & OpenBSD have it the NOMAN way. It'd be nice > to be consistent (unless anyone has a particularly good reason for us > not to be). > You are probably mistaken. OpenBSD has it this way in their bsd.lkm.mk: .if !defined(MAN) MAN= ${LKM}.1 .endif # !defined(MAN) NetBSD has it this way in their bsd.kmod.mk: .if !defined(MAN) MAN= ${KMOD}.4 .endif Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message