Date: Wed, 28 Feb 2024 00:47:37 -0800 From: Chris <i.h8.git@BSDforge.com> To: Mathieu Arnold <mat@freebsd.org> Cc: "Jason E. Hale" <jhale@freebsd.org>, Gleb Popov <arrowd@freebsd.org>, Daniel Engberg <daniel.engberg.lists@pyret.net>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 36c21f98ff44 - main - benchmarks/ttcp: Update to 1.13 Message-ID: <9bec2572dac3452df066367cd1ac47d7@BSDforge.com> In-Reply-To: <7wtjaex6ht2sqsm26atlimduwcydcfs57hihspupjknfjz2ljs@w4fiirdt2djw> References: <c3ddafc7035aca09ed4be08afec4baec@mail.infomaniak.com> <CALH631kKRuT89gUqr8mbjNuZ5KUy5wqpSA5hmbY3qbLxxDoxxA@mail.gmail.com> <e6da26b9f5e9efc7a97a553c70e35565@mail.infomaniak.com> <CALH631kRw3zYpOBTBM6mr1Ozrf5LSa2CimaKd3YP4fVP4TTifg@mail.gmail.com> <e5b1eafae561377530a381f40c0d3c25@BSDforge.com> <xto3yslp2i4y4gna52psg7ck2fxxwabuoafelfnjpvi7hukmrp@j6xpigf6kzhk> <030d157421488bff9ba33907668ba385@BSDforge.com> <w2akal27ms5mwq7t2n4vysm5f3f6dmh74vy7mihhenpvxn6afo@wehrqc4jgogk> <a9eaefa98d9c5a7d2f7534dbabb9604c@BSDforge.com> <CAJE75NGcniVcdnCwKV6KtR5WNxEB2qdvFQ_HvrUx_yWYjBMWiQ@mail.gmail.com> <7wtjaex6ht2sqsm26atlimduwcydcfs57hihspupjknfjz2ljs@w4fiirdt2djw>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-02-27 21:25, Mathieu Arnold wrote:
> On Tue, Feb 27, 2024 at 10:57:36PM -0500, Jason E. Hale wrote:
>> On Tue, Feb 27, 2024 at 5:14 PM Chris <i.h8.git@bsdforge.com> wrote:
>> >
>> > On 2024-02-27 00:44, Mathieu Arnold wrote:
>> > > On Tue, Feb 27, 2024 at 12:25:35AM -0800, Chris wrote:
>> > >> On 2024-02-26 22:28, Mathieu Arnold wrote:
>> > >> > On Mon, Feb 26, 2024 at 08:48:02AM -0800, Chris wrote:
>> > >> > > On 2024-02-25 04:37, Gleb Popov wrote:
>> > >> > > > On Sun, Feb 25, 2024 at 3:34 PM Daniel Engberg
>> > >> > > > <daniel.engberg.lists@pyret.net> wrote:
>> > >> > > > > Hi,
>> > >> > > > >
>> > >> > > > > URL(s) for how we fetch releases/archives from Codeberg
>> > >> > > >
>> > >> > > > Ah, sorry, I just wasn't aware we're standardizing on this. Out of
>> > >> > > > curiosity, what's the rationale behind the
>> > >> > > > "${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/"
>> > >> > > As I indicated in the pr(1) (276759) when you brought this up. The above
>> > >> > > does not work:
>> > >> > >
>> > >> > > # make -DBATCH fetch
>> > >> > > => ttcp-1.13.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
>> > >> > > => Attempting to fetch
>> > >> > > https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz
>> > >> > > fetch: https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz:
>> > >> > > Not Found
>> > >> > >
>> > >> > > Using *any* form of DIST(VERSION)PREFIX/SUFFIX/NAME is no closer to
>> > >> > > returning anything
>> > >> >
>> > >> > Well, this is because the port is missing DISTVERSIONPREFIX=ttcp- as the
>> > >> > tag is ttcp-1.13, and not 1.13.
>> > >> Thanks for the reply, Mathieu.
>> > >> That causes it to attempt to fetch ttcp-ttcp-1.13.tar.gz
>> > >>
>> > >> PORTNAME= ttcp
>> > >> PORTVERSION= 1.13
>> > >> DISTVERSIONPREFIX=ttcp-
>> > >> CATEGORIES= benchmarks net
>> > >> MASTER_SITES= https://codeberg.org/BSDforge/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
>> > >
>> > > MASTER_SITES= https://codeberg.org/BSDforge/ttcp/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
>> > ...
>> > => ttcp-ttcp-1.13.tar.gz is spelled incorrectly.
>> > thanks for trying. :)
>>
>> Please disregard my previous message.
>>
>> Simply setting:
>>
>> MASTER_SITES=
>> https://codeberg.org/BSDforge/ttcp/archive/${PORTNAME}-${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/
>>
>> fixes the issue for me. I was taken a bit off-guard with ${PORTNAME}
>> being a part of the tagname, which is rather unusual, but it fetches
>> nicely from codeberg with this string.
>
> Please, no, set DISTVERSIONPREFIX=${PORTNAME}-, don't change the url
> template.
I can wrap my head around that. Thanks. I'll use that in all my Codeberg
hosted ports
going forward. Thanks, Mathieu! :)
Now. If we could only add Codeberg to bsd.sites.mk. We could even add
expansions like
CB_ACCOUNT, CB_PROJECT, MASTERSITES= CB... :)
--Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9bec2572dac3452df066367cd1ac47d7>