From owner-freebsd-current@freebsd.org Sun Jun 18 12:37:02 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E22ED90AED for ; Sun, 18 Jun 2017 12:37:02 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660061.outbound.protection.outlook.com [40.107.66.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BED166EAE4 for ; Sun, 18 Jun 2017 12:37:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM (10.165.218.133) by YTXPR01MB0192.CANPRD01.PROD.OUTLOOK.COM (10.165.218.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1157.12; Sun, 18 Jun 2017 12:36:59 +0000 Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) by YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) with mapi id 15.01.1178.018; Sun, 18 Jun 2017 12:36:59 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: adding extern maxbcachebuf to param.h Thread-Topic: adding extern maxbcachebuf to param.h Thread-Index: AQHS6C7nwgv6HgWDQU2k0FnNDnYIrg== Date: Sun, 18 Jun 2017 12:36:59 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTXPR01MB0192; 7:vvgShjeXrM0xbnCj+le/6d4lh+7ODDoQire8PSD4cuVWk4D0x5hlgKwjt+dzlES01CLRItdqfjK8KBmJPq+8AleatLYYL06ax/1HSqdK+uMwINC3TOc1ftlqO/hH2eka0Be2gFqt++nUKorptLK9UmwSyeJNa34cOg7CiROf4UHUEX6lGYbEmD097xaW9k6SGjYiTC/LZIB39L0T86G7ZLGJL/v7R8JobbP/RnQo2cNSnAkQnkWDmSIgsiXA69irdNm7HP7U7vZBjrcBnc9MVFoDqW+Bd5sLt+Fri8vLJf5/k+iWreNOBaVNtER828MED8xVEAQgpSVuH7HFReWm//t8lyNLgsq1W9m7XEH7EcRiIrSYNt2G1VQJ+tsxSY8MLmhf3TdEQMRJ6AKgkTUqsBMGZeLQMW2HvPsOQihqLmnmn9f4o1JRte+lCYiHAn9bjuSLcVaTQLqBCFkVJsQ1wQMuwCMRNPYQdmRsCaJCFZwjNGJK47QJd5L620QOH77//8Gov98VIJZRG6WUcWYcMDmVpHUraULjOVo57YZA8Aq8x1D+yYQ7ILCdl9CVIt9qWuKHMRCJBiN7A7y3FckyhOmSE+Qb2dJmiRbWjGU5rdHSehCJdKohPeSduCYUaOxwz5DEHGQnxOec7SgSkPEHwwwUu4tFwTKHcGAnDk6YXMGOEmkd91J44nM5QaIVXWuLvg0veHT7pthWkzMI1JoojsorJW2+cpH2aZ9P804ek1LmtJmYxdjFY2cpff8bDEpQhz4zHaAZaN5jowiuMbGh1IzkyuthfqeHfptAleS+wZg= x-ms-traffictypediagnostic: YTXPR01MB0192: x-ms-office365-filtering-correlation-id: 19fcd26b-9842-4ed5-8d3d-08d4b646b69a x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:YTXPR01MB0192; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:YTXPR01MB0192; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:YTXPR01MB0192; x-forefront-prvs: 034215E98F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39840400002)(39410400002)(39450400003)(2501003)(53936002)(122556002)(14454004)(2906002)(7696004)(305945005)(9686003)(74482002)(5660300001)(74316002)(6916009)(54356999)(77096006)(50986999)(478600001)(55016002)(110136004)(38730400002)(6436002)(189998001)(33656002)(25786009)(6506006)(86362001)(2900100001)(102836003)(8936002)(81166006)(8676002)(3660700001)(2351001)(3280700002)(5640700003); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0192; H:YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2017 12:36:59.3161 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0192 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 12:37:02 -0000 My recent commit (r320062) broke the arm build when it added extern int maxbcachebuf; to sys/param.h. Although I don't understand the actual failure, I believe it is caused by arm/arm/elf_note.S including param.h and then using the ELFNOTE() macro. As a temporary fix, I have committed r320070, which removes the definition from sys/param.h. This brings me to the question of how best to fix this? 1 - Just leave it the way it is now, where "extern int maxbcachebuf" isn't = defined in a generic include file and needs to be defined as above before use. 2 - Add "!defined(LOCORE)" to the definition of it in sys/param.h, which I = believe will also fix the problem. 3 - Put it in some other sys/*.h file which never gets included in assemble= r files. What .h would be appropriate? Once I have answers to the above, I can update the fix. Thanks, rick=