From owner-cvs-all  Sun May 20  4:52:27 2001
Delivered-To: cvs-all@freebsd.org
Received: from kalaid.f2f.com.ua (kalaid.f2f.com.ua [62.149.0.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3812837B424; Sun, 20 May 2001 04:52:18 -0700 (PDT)
	(envelope-from sobomax@mail-in.net)
Received: from mail.uic-in.net (root@[212.35.189.4])
	by kalaid.f2f.com.ua (8.11.3/8.11.1) with ESMTP id f4KBrQE53732;
	Sun, 20 May 2001 14:53:28 +0300 (EEST)
	(envelope-from sobomax@mail-in.net)
Received: from notebook.vega.com (das0-l104.uic-in.net [212.35.189.231])
	by mail.uic-in.net (8.11.3/8.11.3) with ESMTP id f4KBppr02728;
	Sun, 20 May 2001 14:51:52 +0300 (EEST)
	(envelope-from sobomax@mail-in.net)
Date: Sun, 20 May 2001 14:51:52 +0300 (EEST)
Message-Id: <200105201151.f4KBppr02728@mail.uic-in.net>
To: ru@FreeBSD.ORG
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
From: Maxim Sobolev <sobomax@mail-in.net>
Reply-To: sobomax@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.bin Makefile src/usr.bin/scrshot Makefile scrshot.1 scrshot.c src/usr.sbin/vidcontrol vidcontrol.1 vidcontrol.c
X-Mailer: Pygmy (v0.5.8)
In-Reply-To: <20010520141504.E3338@sunbay.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 20 May 2001 14:15:04 +0300, Ruslan Ermilov wrote:
> On Fri, May 18, 2001 at 11:47:36PM -0700, Maxim Sobolev wrote:
> > sobomax     2001/05/18 23:47:36 PDT
> > 
> >   Modified files:
> >     usr.bin              Makefile 
> >     usr.sbin/vidcontrol  vidcontrol.1 vidcontrol.c 
> >   Removed files:
> >     usr.bin/scrshot      Makefile scrshot.1 scrshot.c 
> >   Log:
> >   Move scrshot(1) functionality into vidcontrol(1).
> >   
> >   Suggested by:		many
> >   Not objected to by:	nik (scrshot co-author)
> >   
> >   Revision  Changes    Path
> >   1.160     +1 -2      src/usr.bin/Makefile
> >   1.35      +138 -1    src/usr.sbin/vidcontrol/vidcontrol.1
> >   1.37      +86 -4     src/usr.sbin/vidcontrol/vidcontrol.c
> > 
> You should have waited longer in a review phase...

Yes, I know that normal review period should be much
longer than that, but this case was slightly special
because of the following reasons:

1) It was necessary to minimise effect of introduction and
subsequent removal of scrshot(1) utility (read number of
-current users that will get stale /usr/bin/scrshot and
corresponding manpage).

2) One of the primary authors of the tool (nik) told that he
has absolutely no problems with that change. Several other
committers agreed that scrshot functionality has to be
merged into vidcontrol.

3) The change was pretty trivial.

In any case I'm apologising if that caused any problems
to you or to anybody else.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message