From owner-freebsd-current@FreeBSD.ORG Mon Dec 8 10:16:23 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B510416A4CF for ; Mon, 8 Dec 2003 10:16:23 -0800 (PST) Received: from chortos.wingnet.net (chortos.wingnet.net [206.30.57.3]) by mx1.FreeBSD.org (Postfix) with SMTP id A8B5943FD7 for ; Mon, 8 Dec 2003 10:16:20 -0800 (PST) (envelope-from jesse@wingnet.net) Received: (qmail 82598 invoked by uid 3848); 8 Dec 2003 18:16:19 -0000 Received: from jesse@wingnet.net by chortos.wingnet.net by uid 1003 with qmail-scanner-1.20rc3 (clamuko: 0.60. Clear:RC:1:. Processed in 0.030875 secs); 08 Dec 2003 18:16:19 -0000 X-Qmail-Scanner-Mail-From: jesse@wingnet.net via chortos.wingnet.net X-Qmail-Scanner: 1.20rc3 (Clear:RC:1:. Processed in 0.030875 secs) Received: from makrothumia.wingnet.net (HELO 192.168.1.47) (206.30.215.5) by chortos.wingnet.net with SMTP; 8 Dec 2003 18:16:19 -0000 From: Jesse Guardiani Organization: WingNET To: Sean Chittenden , Mathew Kanner Date: Mon, 8 Dec 2003 13:16:18 -0500 User-Agent: KMail/1.5.4 References: <20031203060710.GJ54011@cnd.mcgill.ca> <20031203165719.GL54011@cnd.mcgill.ca> <20031204230208.GS16547@perrin.nxad.com> In-Reply-To: <20031204230208.GS16547@perrin.nxad.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200312081316.18170.jesse@wingnet.net> cc: freebsd-current@FreeBSD.org Subject: Re: please test pcm channel patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2003 18:16:23 -0000 On Thursday 04 December 2003 18:02, Sean Chittenden wrote: > > > > > Hello All, > > > > > Please test this PCM patch. It creates seperate locking > > > > > classes for PCM channels and should prevent the warning where > > > > > multiple mutexes from the same class are held (as reported > > > > > recently). I believe this to be a good strategy as it masks fewer > > > > > errors. > > > > > > > > I can confirm that this patch fixes my LOR for pcm(4). -sc > > > > > > Bah! I got 30min into playing tunes and picked the same LOR up not > > > more than 5min after sending this. :( Sorry for the false alarm. > > > > > > acquiring duplicate lock of same type: "pcm record channel" > > > 1st pcm0:record:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:144 > > > 2nd pcm0:play:0 @ /usr/src/sys/dev/sound/pcm/dsp.c:146 > > > Stack backtrace: > > > > Sean, > > I found the mistake, I assumed that a variable was initialized > > when it wasn't. Sorry for asking you to test a stupid patch before. > > Please try this one. > > Haven't had a LOR in the last 24hrs, I think you got a winner here. Ditto here too (except it wasn't an LOR in the first place). I've been running this patch since Friday with no backtraces and no problems. Here's my pcm dmesg entry for some more info about my sound hardware: pcm0: port 0x18c0-0x18ff,0x1c00-0x1cff irq 5 at device 31.5 on pci0 pcm0: I'd also like to note that before this patch (5.1-RELEASE and the original 5.2-BETA) my XMMS would periodically halt every 10 or 20 minutes with a message about /dev/dsp0.0 not being a valid device or something. I haven't seen this behavior at all since installing this patch. My music has been streaming for 4 hours straight with no interruptions! The whole XMMS halting music thing has been incredibly annoying ever since I switched to 5.1-RELEASE back in June 2003. It's very sweet to know that I played a small part in squashing that bug. Thanks for the patch! Has it been committed yet? I'd love to see this make it into 5.2-RELEASE. -- Jesse Guardiani, Systems Administrator WingNET Internet Services, P.O. Box 2605 // Cleveland, TN 37320-2605 423-559-LINK (v) 423-559-5145 (f) http://www.wingnet.net