From owner-freebsd-emulation@FreeBSD.ORG Sun Aug 3 07:38:56 2008 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF3131065677 for ; Sun, 3 Aug 2008 07:38:56 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id 3295A8FC15 for ; Sun, 3 Aug 2008 07:38:55 +0000 (UTC) (envelope-from chagin.dmitry@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so2137142fgb.35 for ; Sun, 03 Aug 2008 00:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:to:cc:subject :in-reply-to:message-id:references:user-agent:mime-version :content-type:from; bh=p+tkFfimj4MUtW/g5iLLZLvG0s3DnS/WugIj7PgyHZs=; b=SqTyBdXRMPtql5Kv03SUa2j1qxfDlxraDGj/NKYIoLYjlq59aaa/5XsOkRPlRaATgO Xp/IAvIWcxWH63xG0OKEtArBRrg/+kTM3jLvsx3H+0RFerWsH2c0nqEatqtxEXXm2iFQ MnNN/R96PVSRq7R1qJHU0qQGCs0e272v1atJo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:to:cc:subject:in-reply-to:message-id:references:user-agent :mime-version:content-type:from; b=VUY9LMyyJWJx268f+D7NoL2gUptRrn9b1Oj4Wg6AkDa0/f1V0jh+WTqMuE9YnZAoW5 OH5mcHmDmWMtSCuRsuWkxe3Jc6GfLV29nHxH6VhJ6hz354L6l1WmovZAB0Ld/Q2I7L5i ekPD/g0Ee0zd2cmoM5AbnS0M2ikl3pSyL1SAU= Received: by 10.86.23.17 with SMTP id 17mr9183661fgw.32.1217749134754; Sun, 03 Aug 2008 00:38:54 -0700 (PDT) Received: from ora.chd.net ( [78.107.232.239]) by mx.google.com with ESMTPS id d6sm2787545fga.2.2008.08.03.00.38.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 03 Aug 2008 00:38:54 -0700 (PDT) Date: Sun, 3 Aug 2008 11:38:49 +0400 (MSD) To: Roman Divacky In-Reply-To: <20080803073044.GA4624@freebsd.org> Message-ID: References: <20080802222109.GA78151@freebsd.org> <20080803073044.GA4624@freebsd.org> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed From: Chagin Dmitry Cc: freebsd-emulation@freebsd.org, Chagin Dmitry Subject: Re: [PATCH]Re: kern/122318 (CMake core dumping, chroot exiting) X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Aug 2008 07:38:56 -0000 On Sun, 3 Aug 2008, Roman Divacky wrote: > On Sun, Aug 03, 2008 at 02:54:53AM +0400, Chagin Dmitry wrote: >> On Sun, 3 Aug 2008, Roman Divacky wrote: >> >>> On Sun, Aug 03, 2008 at 12:53:58AM +0400, Chagin Dmitry wrote: >>>> On Wed, 23 Jul 2008, Sean C. Farley wrote: >>>> >>>>> I am seeing if anyone has any insight on this PR (kern/122318[1]). It >>>>> would be nice to once again build using cmake within a Linux chroot. :) >>>>> >>>>> Basically, the bug is that not only that cmake is dumping core; it is >>>>> also forcing the user out of the chroot environment. Here is the >>>>> command used to start the chroot: >>>>> /compat/linux/usr/sbin/chroot su - >>>>> >>>>> Thank you. >>>>> >>>>> Sean >>>>> 1. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/122318 >>>>> >>>> >>>> here patches for -current and releng_7: >>>> http://78.107.232.239/rt_signals-current.patch >>>> http://78.107.232.239/rt_signals-releng_7.patch >>>> >>>> what patch do: >>>> - rt sigtramp code works (this solves PR) >>>> - align stack pointers >>>> - remove kern_sigaltstack() at the end of rt_sigreturn(), it's a bogus. >>>> Here there is some information on it: >>>> http://www.ussg.iu.edu/hypermail/linux/kernel/0405.2/1283.html >>> >>> I quickly skimmed over it and it looks correct, but please avoid >>> making gratuitous changes like moving stuff before comment after >>> the comment etc. >>> >> >> I have simply transferred a line on place where it should be :) > > no problem with the change itself but including it in the patch > makes the patch bigger and harder to review ok > >>> I will do a little more thorough review but so far it looks good >>> >> >> and please, test it on i386. > > test with the cmake? > no, with special test http://78.107.232.239/tst_rtsig.c cmake differs only that that uses select() and I sigsuspend() for sleep. -- Have fun! chd