Date: Tue, 3 Aug 2021 21:09:40 -0400 From: Ed Maste <emaste@freebsd.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: "freebsd-toolchain@FreeBSD.org" <freebsd-toolchain@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Dimitry Andric <dim@freebsd.org>, Alexander Richardson <arichardson@freebsd.org> Subject: Re: Migrating to LLVM binutils tools (ar, nm, addr2line, etc.) Message-ID: <CAPyFy2BMOhsbF9Hi7TXC5anV63SoxbEeyiM3ZNX7mHVvo=U0wQ@mail.gmail.com> In-Reply-To: <20210802131132.c7egr6cphq322qcj@mutt-hbsd> References: <CAPyFy2AP8b4QAU7S9_Yenj8VCWwrBUitRGAAuPiExiX3wBNu%2Bw@mail.gmail.com> <20210802131132.c7egr6cphq322qcj@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2 Aug 2021 at 09:11, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: > > For most cases, when elftc-ar fails, it does not set the exitcode to > non-zero. This tricks the ports tree to continue to build a port where > elftc-ar actually errored. Thanks for the notice - I didn't see this email until now, but saw the related discussion on HardenedBSD's IRC channel this morning. Note that FreeBSD ar is different from ELF Tool Chain's ar; the latter is a fork of FreeBSDs, and there are some distinct bug fixes or improvements in each version that are not present in the other. Here FreeBSD's ar is buggy, and llvm-ar, GNU ar, and ELF Tool Chain's ar all return a non-zero exit code. Code review with fix for FreeBSD's ar: https://reviews.freebsd.org/D31402 Exp-run request: https://bugs.freebsd.org/257599
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BMOhsbF9Hi7TXC5anV63SoxbEeyiM3ZNX7mHVvo=U0wQ>