From nobody Tue Apr 12 05:20:12 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1C4EE11D8D5D for ; Tue, 12 Apr 2022 05:22:24 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KcvHL1RHrz4ZNc; Tue, 12 Apr 2022 05:22:22 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-lj1-f175.google.com with SMTP id b21so3179193ljf.4; Mon, 11 Apr 2022 22:22:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VZ3Pk0lxbzDIAa3CfxsVPFols4iXR3bCtWX8naWRsLM=; b=IFTZeAwYVuo6vVE3VvS+br+0hrTq2ZBcQRNU/DMdcToTGxQ2PhBI7SFGdk2Rx0pZoY MYnRWHvuYWACG6vuE3euGfspIc6DNncI1a1RyNHDwwZyYejGIx6arcCvEHAE9VP5ShVx Y4GMgvrfDItmL2lGw9c6dnba53Qf+9WLEbdnHWlMrWesGdH5BAxrq1MkwcqPjmdEQgif pLTRbhV9EAEgbkTbbK7lvhBRp93pS4cpixbzUJ39FdIKrkYRtIJ64azRhIraIGgbRDSF 16oWrCMd9Jykj9loeTAFDDxmXICKzqyyrHo1JLI2LaGZZf/Jd3Aeu55cXcFrJxqnBAj7 DPIg== X-Gm-Message-State: AOAM5320US20PUF/PzyGx3BYRowa1Ex27FKtdL0S94cYAaY6Q8rV2qY8 /JS82YSYh1Z/Xa3oFv8CLCmX0D5aE/et+w9K X-Google-Smtp-Source: ABdhPJxF9iuWAao6VKfum5Tap22GlYaw0ikZa1zdClMBsnc7HeG9KwsWrLrhjoiADilXqZVtDzhkUg== X-Received: by 2002:a2e:8e92:0:b0:24b:61e5:7996 with SMTP id z18-20020a2e8e92000000b0024b61e57996mr6016661ljk.67.1649740934422; Mon, 11 Apr 2022 22:22:14 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id w18-20020a2ea3d2000000b0024b548a4abasm1109237lje.88.2022.04.11.22.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 22:22:13 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id b21so3179136ljf.4; Mon, 11 Apr 2022 22:22:13 -0700 (PDT) X-Received: by 2002:a2e:9549:0:b0:24b:4f99:4e76 with SMTP id t9-20020a2e9549000000b0024b4f994e76mr11924370ljh.350.1649740933235; Mon, 11 Apr 2022 22:22:13 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <168EF37D-8591-4F8C-93E1-F15FDA10F311@FreeBSD.org> <9ZQ1RgjxwamYo_YNKUEfd5Aq7X9m6pUgRdbyxcj71_qRzdufKX8g9V-Xe8jsCn8b6Uo3jvVA3IwtJeYm7N4A6i35MqBI5PrVBuf_rKxjd60=@insane.engineer> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Tue, 12 Apr 2022 07:20:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Build issue with i386 port To: jbo@insane.engineer Cc: Dimitry Andric , "ports@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4KcvHL1RHrz4ZNc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-1.85 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-0.48)[-0.479]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; R_MIXED_CHARSET(0.62)[subject]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-0.998]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.179:received,209.85.208.175:from]; MLMMJ_DEST(0.00)[ports]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.175:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Apr 11, 2022 at 10:12 PM wrote: > > I'd have a follow up question based on your commit: What's the reason for= not increasing PORTVERSION after modifying the port? That the resultant package will not change and that the port becomes buildable where it wasn't previously. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming Cheers. > > ~ Joel > > ------- Original Message ------- > > On Monday, April 11th, 2022 at 20:18, Fernando Apestegu=C3=ADa wrote: > > > On Mon, Apr 11, 2022 at 8:14 PM jbo@insane.engineer wrote: > > > > > > I would cherry pick the patch with PATCHFILES: > > > > > > > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-d= istfiles > > > > > > > > +PATCH_SITES=3D https://github.com/Dr-Noob/cpufetch/commit/ > > > > > > > > +PATCHFILES=3D 0db9f1f5c26e57a6383f4609c5605ed5d3d41fd1.patch:-p1 > > > > > > > > I already have the change ready to push it. Shall we? > > > > > > Green light from my side! > > > > > > Thank you for your efforts, it's greatly appreciated. > > > > Done. https://cgit.FreeBSD.org/ports/commit/?id=3Dc6e6c7f15310fe8816924= 47dbb56749f0860670b > > > > Cheers! > > > > > ------- Original Message ------- > > > > > > On Monday, April 11th, 2022 at 20:10, Fernando Apestegu=C3=ADa fernap= e@freebsd.org wrote: > > > > > > > On Mon, Apr 11, 2022 at 8:04 PM jbo@insane.engineer wrote: > > > > > > > > > Oooh! This is so obvious it almost hurts... > > > > > > > > > > So basically what happened is that upstream's v1.00 release that = the port is building didn't yet support i386. Meanwhile, I was able to comp= ile > > > > > > > > > > successfully on my VMs because I was using the main/master branch= which does support i386. > > > > > > > > > > I hope we can just consider this a beginner's mistake :p > > > > > > > > > > This brings me to the next question: According to Repology [1], a= lot of packages are using the v1.01 tag whereas our port is currently > > > > > > > > > > using v1.00. The reason I didn't update the port yet is because t= here isn't an official release on the upstream's GitHub page. > > > > > > > > > > What is the recommended/preferred way of handling this? > > > > > > > > I would cherry pick the patch with PATCHFILES: > > > > > > > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-d= istfiles > > > > > > > > +PATCH_SITES=3D https://github.com/Dr-Noob/cpufetch/commit/ > > > > > > > > +PATCHFILES=3D 0db9f1f5c26e57a6383f4609c5605ed5d3d41fd1.patch:-p1 > > > > > > > > I already have the change ready to push it. Shall we? > > > > > > > > > [1] https://repology.org/project/cpufetch/versions > > > > > > > > > > Best regards, > > > > > > > > > > ~ Joel > > > > > > > > > > ------- Original Message ------- > > > > > > > > > > On Monday, April 11th, 2022 at 19:57, Dimitry Andric dim@FreeBSD.= org wrote: > > > > > > > > > > > On 11 Apr 2022, at 19:53, Fernando Apestegu=C3=ADa fernape@free= bsd.org wrote: > > > > > > > > > > > > > On Mon, Apr 11, 2022 at 7:24 PM jbo@insane.engineer wrote: > > > > > > > > > > > > ... > > > > > > > > > > > > > > gmake[1]: Entering directory '/wrkdirs/usr/ports/sysutils/c= pufetch/work/cpufetch-1.00' > > > > > > > > > > > > > > > > Makefile:38: Unsupported arch detected: i386. See https://g= ithub.com/Dr-Noob/cpufetch#1-support > > > > > > > > > > > > > > > > Makefile:39: If your architecture is supported but the comp= ilation fails, please open an issue in https://github.com/Dr-Noob/cpufetch/= issues > > > > > > > > > > > > > > > > Makefile:40: *** Aborting compilation. Stop. > > > > > > > > > > > > > > > > gmake[1]: Leaving directory '/wrkdirs/usr/ports/sysutils/cp= ufetch/work/cpufetch-1.00' > > > > > > > > > > > > > > > > =3D=3D=3D> Compilation failed unexpectedly. > > > > > > > > > > > > > > > > Try to set MAKE_JOBS_UNSAFE=3Dyes and rebuild before report= ing the failure to > > > > > > > > > > > > > > > > the maintainer. > > > > > > > > > > > > > > > > *** Error code 1 > > > > > > > > > > > > > > > > Upstream's Makefile uses $(shell uname -m) to determine the= architecture [2]. My VMs are successfully reporting this as > > > > > > > > > > > > > > > > i386 which upstream's Makefile appears to support explicitl= y. After all, I'm also able to build this software > > > > > > > > > > > > > > > > on those VMs if just cloning & running gmake manually. > > > > > > > > > > > > > > > > I'm not really sure where to go from here. As I can build t= he software in FreeBSD i386 VMs I think > > > > > > > > > > > > > > > > that the issue is related to my port and not upstream. But = then again, the build fails "within" upstream's Makefile. > > > > > > > > > > > > > > > > Could somebody help me out here? > > > > > > > > > > > > > > When the Makefile checks the output of uname -m, it compares = the > > > > > > > > > > > > > > result with a list of values that includes i686 but not i386. > > > > > > > > > > > > > > I think a simple REINPLACE_CMD would suffice here. > > > > > > > > > > > > > > Since I failed to detect this, do you want me to fix it in th= e repo? I > > > > > > > > > > > > > > will also send a patch upstream. > > > > > > > > > > > > No need :) > > > > > > > > > > > > https://github.com/Dr-Noob/cpufetch/commit/0db9f1f5c26e57a6383f= 4609c5605ed5d3d41fd1 > > > > > > > > > > > > -Dimitry