From owner-freebsd-current@FreeBSD.ORG Sun Aug 19 11:56:02 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3224716A46C; Sun, 19 Aug 2007 11:56:02 +0000 (UTC) (envelope-from davidt@yadt.co.uk) Received: from outcold.yadt.co.uk (outcold.yadt.co.uk [81.187.204.178]) by mx1.freebsd.org (Postfix) with ESMTP id D39EE13C45A; Sun, 19 Aug 2007 11:56:01 +0000 (UTC) (envelope-from davidt@yadt.co.uk) Received: from localhost (localhost [127.0.0.1]) by outcold.yadt.co.uk (Postfix) with ESMTP id 466DF57A58; Thu, 19 Jul 2007 18:48:50 +0100 (BST) X-Virus-Scanned: amavisd-new at yadt.co.uk Received: from outcold.yadt.co.uk ([127.0.0.1]) by localhost (outcold.yadt.co.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gsx5qCOzafFx; Thu, 19 Jul 2007 18:48:47 +0100 (BST) Received: by outcold.yadt.co.uk (Postfix, from userid 1001) id 7050457A5A; Thu, 19 Jul 2007 18:48:47 +0100 (BST) From: David Taylor To: "Wojciech A. Koszek" , freebsd-current@freebsd.org Message-ID: <20070719174847.GA5853@outcold.yadt.co.uk> Mail-Followup-To: "Wojciech A. Koszek" , freebsd-current@freebsd.org References: <20070506164247.GA77786@FreeBSD.czest.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20070506164247.GA77786@FreeBSD.czest.pl> User-Agent: Mutt/1.4.2.3i Cc: Subject: Re: INCLUDE_CONFIG_FILE patches X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 19 Aug 2007 11:56:02 -0000 X-Original-Date: Thu, 19 Jul 2007 18:48:47 +0100 X-List-Received-Date: Sun, 19 Aug 2007 11:56:02 -0000 On Sun, 06 May 2007, Wojciech A. Koszek wrote: > Hello, > > We talked about improved INCLUDE_CONFIG_FILE work some time ago. I > cleaned it up, and I have prepared a patch for the latest -CURRENT. > > It's here: > > http://people.freebsd.org/~wkoszek/patches/kernconf.patch > > If you have any suggestions, please let me know as I'd really like to > see this patch into the tree before RELENG_7. Hi, I've discovered a small problem with this patch (or at least, whatever version is in RELENG_6 as of 2007-07-18). If your config file contains a trigraph (in my case, I had a comment containing "??)"), gcc will process it as a trigraph and produce a warning, which will break the build with a confusing and unhelpful error message in config.c. This caused no problems before the new INCLUDE_CONFIG_FILE option (as the config file wasn't included in the C source file). Not sure what the best solution is, but some kind of warning that this can happen would perhaps save someone 30 minutes of frustration! Alternatively, some method of escaping any potential trigraphs would be great. -- David Taylor