From owner-freebsd-testing@FreeBSD.ORG Mon Sep 8 14:59:48 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D3796F14; Mon, 8 Sep 2014 14:59:48 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 24726198C; Mon, 8 Sep 2014 14:59:47 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id hi2so2826223wib.16 for ; Mon, 08 Sep 2014 07:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+BqMXuuKdUEV2WGcQuIMmgPZXRFA612jjVcmWwlMgG8=; b=TroSHEeFgoCHuVPkDiN2adDZDi7VCO5KkP6FNMpynFSJ4UfRiYGcToVPCB3nM1JVUT UwBhdIA1/d8ZO/98SlTY3DuxizC3UhrcM9wwfF/GZcBsy0JvO8QoK58cjo1MPAkhW94O 48NTR+c65BwMmivrHUXTGwo8y9afjTBjGgaz3ZWQoh9tXwyOkpUfz0Crdw2yNrE/06nL iUmRiDdTbYn64T0wi4dwCB2pEwKYkruAAiPty4e7eEbbvYFJJluaKCGhNLB+4G+59WHU 4Oq9TtFFF3wjiQvyQJjU3NbstpHv581PkFnhDGSkpkGzlaz72JuQBfORSS+1rUduB4Yg mLyg== MIME-Version: 1.0 X-Received: by 10.180.89.36 with SMTP id bl4mr14592297wib.50.1410188386323; Mon, 08 Sep 2014 07:59:46 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.194.126.1 with HTTP; Mon, 8 Sep 2014 07:59:46 -0700 (PDT) In-Reply-To: References: Date: Mon, 8 Sep 2014 08:59:46 -0600 X-Google-Sender-Auth: VVEY3AyMNS-Hn4_3uJwQjAVy76c Message-ID: Subject: Re: Introducing the ZFS test suite From: Alan Somers To: Julio Merino Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" , "zfs-devel@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 14:59:48 -0000 On Mon, Sep 8, 2014 at 8:23 AM, Julio Merino wrote: > On Mon, Aug 25, 2014 at 2:38 PM, wrote: >> I just merged the ZFS test suite to projects/zfsd/head in change 270604. >> [...] >> The ZFS test suite still has some problems. Some of these are >> blocking it from being merged to head: >> * The atf-ksh93 hack. This is not a good thing to officially add to >> ATF, but it would be a lot of work to convert the test programs to run >> under sh. Especially because of the use of ksh arrays. > > As we discussed, agreed that this is a bit hackish, but I think this > is a reasonable compromise and the hack is unlikely to break anytime > soon. (Haven't looked at the specifics that were implemented though.) > Therefore, I would personally not consider a "rewrite in sh" to be a > blocker for merging into head. Good. That certainly reduces the workload. > > > Remember, don't run these tests on a production system. > > What's the plan for this? > > Are the tests somehow disabled by default so that a user running the > full test suite is not tripped by this? Currently, most if not all of the tests reference the test_suites.FreeBSD.disks variable. We should add it to require.configs, and then none of them will run by default. The bigger problem, though, is that even if you define that variable, many disks will destroy all pools on cleanup unless you also define the keep_pools variable. It's part of the default_cleanup_noexit function in libtests.kshlib. That must be fixed. > > Or will all the panics and deadlocks be fixed before merging to head? I doubt it. I certainly don't want to wait for it. But merging these tests to head will certainly help to focus attention on those bugs. > > Thanks for doing this!