From nobody Tue Jan 28 18:32:33 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjDRg1sBSz5lvvL for ; Tue, 28 Jan 2025 18:32:47 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjDRf1mSsz3VjN for ; Tue, 28 Jan 2025 18:32:46 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43618283dedso63344295e9.3 for ; Tue, 28 Jan 2025 10:32:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738089165; x=1738693965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=huBeTx4i3pVXwBrySPJc+nsfwsufI4c4tL9kbEbGigo=; b=LM156MKy3ZCdBt+eNwqkcrv+qUI1K/h5uQloKk7ZXDEakajXkquy5xJNKLn1/fqnRO HnQ9BwilOdeUL0CeQ+Z6PL1CXUvZoGN82FdCGKOVJeFiErHcvXfSRsZNE2Pim8SCPFB9 qLYOEAoJjJ1W0tVelF+G89QTRlF7bzVZ1IkPAA9/dCTbfdnW8+XT6jIbdITkQUumKGrg 4OaTvCbPvd/+s9tVGwY69AkrI5pQTPRYeuRdXbHnmlcEd9ptrS22COG34EcOxqWdnScu zb+ZK0g1N+abyiKpN4hSSqmBcE7EKt5k873dY9Dm1METiN4RZKyMs+rKNew+BNs65vep A4xA== X-Forwarded-Encrypted: i=1; AJvYcCUdlOtNB3l7DQEozaqwQCAQTyaNPp3Lx9rBOMsHJY8BancUu0qvAeqE9p/2rkqVqzLU+NxfyUiVNDIXU/y8+2B1V+Kx@freebsd.org X-Gm-Message-State: AOJu0YyfCcRoa43DG2HgWd60v/k/jdx6myibvFdQax3ZsG/pr+QiPQ2T 4Oa1k7t8VUIsOrvi3baUu1eS79bo1NPkymf2op73ae6Zv9/EpR/D3m59CXoGXnI= X-Gm-Gg: ASbGncvVJv1jeFpjluLmMF8S91Cabbvgl68FIvWrTywIpyMmmGfcnL4ubAbLf6v6bHr jQ7ylBr4nif8Fe1p9vPUrgDclpnigY/1E+3EPvcO5n0e1mgY9YigFs+FRxtuN/5p2QSIDEGeARL 2oR9fYHq+OJefWrIEFcCBeYgiNbOC/Z4pWcZDZ3qoBPROamAmEXdydRbBzAwFQMfMvGbPGrrIbG yshzB9qNLxnhpLAn3FLYuRAi4QblWxvMgQ49H/+Gw81nW84rQttW2KJxaSPRZrBrswPhLf1Gnm6 lNfY6IBzJLXdtDm9zp1csQVrGxZ2nQ== X-Google-Smtp-Source: AGHT+IFIzGLZSePkDA6Bqp1glMO0N/RoNZEhk1fdblP14vzaAQxhQiIIOUBZcHCWoULYnSJG0b1BRg== X-Received: by 2002:a05:600c:5027:b0:434:f5c0:3288 with SMTP id 5b1f17b1804b1-43891430ed1mr410363525e9.29.1738089164548; Tue, 28 Jan 2025 10:32:44 -0800 (PST) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c4212sm14366613f8f.87.2025.01.28.10.32.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2025 10:32:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: git: c3450ad127e9 - main - clang: re-downgrade implicit int/function declarations to warning only From: Jessica Clarke In-Reply-To: <202306222111.35MLBAqB066211@gitrepo.freebsd.org> Date: Tue, 28 Jan 2025 18:32:33 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202306222111.35MLBAqB066211@gitrepo.freebsd.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Spamd-Result: default: False [-0.51 / 15.00]; RBL_SENDERSCORE_REPUT_5(1.50)[209.85.128.48:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.91)[-0.908]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; BAD_REP_POLICIES(0.10)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.48:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.48:from] X-Spamd-Bar: / X-Rspamd-Queue-Id: 4YjDRf1mSsz3VjN On 22 Jun 2023, at 22:11, Dimitry Andric wrote: > The branch main has been updated by dim: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc3450ad127e94d3fa67ae337310e59c0= 02f51bfc >=20 > commit c3450ad127e94d3fa67ae337310e59c002f51bfc > Author: Dimitry Andric > AuthorDate: 2023-04-25 19:24:04 +0000 > Commit: Dimitry Andric > CommitDate: 2023-06-22 18:22:33 +0000 >=20 > clang: re-downgrade implicit int/function declarations to warning = only >=20 > This reapplies upstream commit c0141f3c300f by Aaron Ballman: >=20 > Downgrade implicit int and implicit function declaration to = warning only >=20 > The changes in Clang 15.0.0 which enabled these diagnostics as a > warning which defaulted to an error caused disruption for people > working on distributions such as Gentoo. There was an explicit = request > to downgrade these to be warning-only in Clang 15.0.1 with the > expectation that Clang 16 will default the diagnostics to an = error. >=20 > See > = https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror= -implicit-function-declaration/65213 > for more details on the discussion. >=20 > See https://reviews.llvm.org/D133800 for the public review of = these > changes. >=20 > As noted in the upstream discussion, there are many programs that = fail > to configure or build correctly, if these warnings are turned into > errors by default. >=20 > Note that most affected programs in ports are relatively old, and = are > unlikely to be fixed by actually adjusting their declarations, but = by > compiling with -std=3Dgnu89, which downgrades the errors back to = warning > again. Lots of tedious work for very little gain. This remains as a downstream divergence 1.5 years later, but I do not think we should be carrying this indefinitely. Software needs to build with upstream LLVM, and the fact that many ports do not is now biting us for CheriBSD where we use our own external toolchain that does not have such a diff. In my opinion this should be reverted for FreeBSD 15 and it=E2=80=99s long time for ports people to step up or have the = broken ports removed; we can=E2=80=99t keep going on like this with abandonware = holding back forward progress. Jess