From owner-cvs-src@FreeBSD.ORG Tue Aug 3 00:44:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96D5316A4D0; Tue, 3 Aug 2004 00:44:04 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 548E843D68; Tue, 3 Aug 2004 00:44:04 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net [67.127.84.57]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i730i32a019213; Mon, 2 Aug 2004 17:44:03 -0700 Message-ID: <410EDFD2.1030802@root.org> Date: Mon, 02 Aug 2004 17:44:02 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7 (X11/20040702) X-Accept-Language: en-us, en MIME-Version: 1.0 To: cvs-src@freebsd.org, cvs-all@freebsd.org References: <20040803004150.8C6FF16A4F5@hub.freebsd.org> In-Reply-To: <20040803004150.8C6FF16A4F5@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [src] cvs commit: src/sys/dev/eisa eisaconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 00:44:04 -0000 Nate Lawson wrote: > njl 2004-08-03 00:41:47 UTC > > FreeBSD src repository > > Modified files: > sys/dev/eisa eisaconf.c > Log: > Change EISA probing to be less invasive. Instead of probing all slots > unconditionally, stop after the first one (system board) if no EISA hardware > is detected. This fixes a boot hang (i.e. Thinkpad) when ACPI is disabled. > Also, split the probe code into a separate function and do some style cleanup. > > Note that the Adaptec 2842 VLB controller probe is broken by this change > and will fail to probe. It should be fixed separately. > > Revision Changes Path > 1.67 +43 -11 src/sys/dev/eisa/eisaconf.c Reviews and helpful comments from: gibbs, imp -Nate