From owner-svn-src-all@freebsd.org Sat Jan 30 08:51:23 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C4D4A724DD; Sat, 30 Jan 2016 08:51:23 +0000 (UTC) (envelope-from cochard@gmail.com) Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D05410D2; Sat, 30 Jan 2016 08:51:22 +0000 (UTC) (envelope-from cochard@gmail.com) Received: by mail-lf0-x22f.google.com with SMTP id j78so667763lfb.1; Sat, 30 Jan 2016 00:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=MRhTXc977mpKDy+p1xB3To1DC5+T446tSXjxW1QZwEc=; b=F35R36m3ClgWhCv6bBgd0Up725A87RS20f32nGsB5dw5Cg6qCxYfjLh5UnmCKQo1C9 gVWXPcXA9H4V7K3anTMD6QvMUrfAaAKyynC+Vc0coqbhV04Rj3LapVtGgaMi8eB6Lvxy j65Ka+Fv8148spxJVPmdgk1txmR/otg2CQSB75y+0Kie/CjIWJDpqhv6V9EjWjUOFxV+ JYRR6xFiSfBpPziVhnntEVTdgTUU4MxzBnq/bvlrnXxy2UcN5UNdhptpDPW4erZnGC9M 5k2fIhNLU1ZG8x38+vdlj/qZUTaqOkxvXRMilCoyBnITHDpo7Rxkz3Ugw3KdPeFgZXzm +GNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cochard-me.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=MRhTXc977mpKDy+p1xB3To1DC5+T446tSXjxW1QZwEc=; b=OsGXCUBlDX1O2DxotCpqEosez0391UxQH7D5fd83QCtBdU/LqY6oZ6uD+D1S7VpC/x 1a7KelllKbvHbFQpLuwL+F3USg42Q1KYxXEMKDtJ84tYZP1k1xj1/ZNEhs8b3rX5NVIn J1ksNay1vvT6M7uM0PrMcFEAxk9dBDvk2/JTHVjUtS+P1oawxG13ej2Y9a6XjjTS50zG yowLv2e/EWCCUEcpC2fMi0S/jJ+pSEL7jGyh8i2rvtjyhSAkc+DxOdPv6yMJiE6fNQlv ZQAMNdnbp5/J77e2X83GfbSCYqrkcQs+Z3j/dVBT5UuP2wIRqonlyN3fMHRRlIHPank9 YSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=MRhTXc977mpKDy+p1xB3To1DC5+T446tSXjxW1QZwEc=; b=jf7id1BLZ72Mt+nvnWeI1K2YREpb21hnEOGDzkCyR6gg+AmMy+9dw1evOf43wkNgP5 eYKbuldOxl6Sesm5xvSh1n17Or20Jb2SEN3LdY1yxdY4Fg0izLb4jYJe+oTi0uD4dszv Aeg9lJspJWRvcDENf8InDOL9l2fvnOgzSrxTQld86pza2aeRusW5rHFE0e3EwZ8o8k2u 5UX5SUQhHOHDOeworq74Cw4yNzY01/ZkzQiq1HoiTj/JyBx8xnZdNh9O47512faYVYCX /bXp6OdpK44VgSpC0DgWbC1/wuX5gPCF+hNF7Xk++MnS0HiAowgti/3TT7PSBKkf4RNy rPvQ== X-Gm-Message-State: AG10YORkNqqXPD4TpqwMK83/8WhaKNFgikXlgmW5mhCfObDsLRYSLoSQbmqVn0cm8ze092QrP8fwJjWwROtYdw== X-Received: by 10.25.15.226 with SMTP id 95mr5153167lfp.85.1454143880205; Sat, 30 Jan 2016 00:51:20 -0800 (PST) MIME-Version: 1.0 Sender: cochard@gmail.com Received: by 10.25.136.11 with HTTP; Sat, 30 Jan 2016 00:51:00 -0800 (PST) In-Reply-To: <201601300618.u0U6Ibm8005064@repo.freebsd.org> References: <201601300618.u0U6Ibm8005064@repo.freebsd.org> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Sat, 30 Jan 2016 09:51:00 +0100 X-Google-Sender-Auth: ZvHbiXB3WBPbwV1IJd8-fLJkTq8 Message-ID: Subject: Re: svn commit: r295062 - head/sbin/nvmecontrol To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2016 08:51:23 -0000 On Sat, Jan 30, 2016 at 7:18 AM, Warner Losh wrote: > Author: imp > Date: Sat Jan 30 06:18:37 2016 > New Revision: 295062 > URL: https://svnweb.freebsd.org/changeset/base/295062 > > Log: > Implement power command to list all power modes, find out the power > mode we're in and to set the power mode. > > Added: > head/sbin/nvmecontrol/power.c (contents, props changed) > =E2=80=8BHi Warner, my buildworld is no more happy ;-)=E2=80=8B --- power.o --- /usr/src/sbin/nvmecontrol/power.c:44:16: error: invalid application of 'sizeof' to an incomplete type 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ --- all_subdir_kerberos5 --- --- inquire_cred_by_mech.po --- --- all_subdir_sbin --- /usr/src/sbin/nvmecontrol/power.c:60:14: error: incomplete definition of type 'struct nvme_power_state' mpower =3D nps->mp; ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:61:9: error: incomplete definition of type 'struct nvme_power_state' if (nps->mps =3D=3D 0) ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:63:14: error: incomplete definition of type 'struct nvme_power_state' ipower =3D nps->idlp; ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:64:9: error: incomplete definition of type 'struct nvme_power_state' if (nps->ips =3D=3D 1) ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:66:14: error: incomplete definition of type 'struct nvme_power_state' apower =3D nps->actp; ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:67:9: error: incomplete definition of type 'struct nvme_power_state' if (nps->aps =3D=3D 1) ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:71:12: error: incomplete definition of type 'struct nvme_power_state' nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % 1000, ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, ^ /usr/src/sbin/nvmecontrol/power.c:71:35: error: incomplete definition of type 'struct nvme_power_state' nps->nops ? '*' : ' ', nps->enlat / 1000, nps->enlat % 1000, ~~~^ /usr/src/sbin/nvmecontrol/power.c:44:30: note: forward declaration of 'struct nvme_power_state' _Static_assert(sizeof(struct nvme_power_state) =3D=3D 256 / NBBY, etc. =E2=80=8B