From owner-freebsd-hackers  Tue Oct 24 06:22:34 1995
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id GAA11142
          for hackers-outgoing; Tue, 24 Oct 1995 06:22:34 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id GAA11137
          for <freebsd-hackers@freebsd.org>; Tue, 24 Oct 1995 06:22:24 -0700
Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id GAA05988; Tue, 24 Oct 1995 06:22:20 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id GAA27405; Tue, 24 Oct 1995 06:19:30 -0700
Message-Id: <199510241319.GAA27405@corbin.Root.COM>
To: dk+@ua.net
cc: freebsd-hackers@freebsd.org
Subject: Re: patch for PTYs not freed? (2.0.5-R) 
In-reply-to: Your message of "Tue, 24 Oct 95 14:48:23 +0200."
             <199510241248.OAA16789@dog.farm.org> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Tue, 24 Oct 1995 06:19:12 -0700
Sender: owner-hackers@freebsd.org
Precedence: bulk

>I am gotting that same bug which bites me: 
>
>under screen, create virtual console (using PTY), run telnet/rlogin under it,
>kill the shell process (telnet not killed), re-create virtual console 
>(same PTY used), alas, I got input from shell/old telnet process intermixed.
>
>secutity hole as well.
>
>I remember discussion about this some time ago; was anything like a patch
>fixing the problem issued? 

   The problem has been fixed in both -current and -stable.

Index: tty_pty.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/tty_pty.c,v
retrieving revision 1.20
diff -c -r1.20 tty_pty.c
*** 1.20	1995/09/08 11:08:38
--- tty_pty.c	1995/09/21 01:42:42
***************
*** 31,37 ****
   * SUCH DAMAGE.
   *
   *	@(#)tty_pty.c	8.2 (Berkeley) 9/23/93
!  * $Id: tty_pty.c,v 1.20 1995/09/08 11:08:38 bde Exp $
   */
  
  /*
--- 31,37 ----
   * SUCH DAMAGE.
   *
   *	@(#)tty_pty.c	8.2 (Berkeley) 9/23/93
!  * $Id: tty_pty.c,v 1.21 1995/09/19 12:26:47 bde Exp $
   */
  
  /*
***************
*** 322,328 ****
  	}
  
  	tp->t_oproc = 0;		/* mark closed */
- 	tp->t_session = 0;
  	return (0);
  }
  
--- 322,327 ----