From owner-cvs-src@FreeBSD.ORG Tue Feb 8 16:25:51 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08AED16A4CE; Tue, 8 Feb 2005 16:25:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF39043D45; Tue, 8 Feb 2005 16:25:50 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j18GPo5l090459; Tue, 8 Feb 2005 16:25:50 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j18GPoeA090458; Tue, 8 Feb 2005 16:25:50 GMT (envelope-from phk) Message-Id: <200502081625.j18GPoeA090458@repoman.freebsd.org> From: Poul-Henning Kamp Date: Tue, 8 Feb 2005 16:25:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c ffs_extern.h ffs_inode.c ffs_rawread.c ffs_snapshot.c ffs_softdep.c ffs_vfsops.c ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2005 16:25:51 -0000 phk 2005-02-08 16:25:50 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_balloc.c ffs_extern.h ffs_inode.c ffs_rawread.c ffs_snapshot.c ffs_softdep.c ffs_vfsops.c ffs_vnops.c Log: For snapshots we need all VOP_LOCKs to be exclusive. The "business class upgrade" was implemented in UFS's VOP_LOCK implementation ufs_lock() which is the wrong layer, so move it to ffs_lock(). Also, as long as we have not abandonned advanced vfs-stacking we should not preclude it from happening: instead of implementing a copy locally, use the VOP_LOCK_APV(&ufs) to correctly arrive at vop_stdlock() at the bottom. Revision Changes Path 1.49 +4 -6 src/sys/ufs/ffs/ffs_balloc.c 1.64 +2 -1 src/sys/ufs/ffs/ffs_extern.h 1.100 +3 -3 src/sys/ufs/ffs/ffs_inode.c 1.22 +2 -1 src/sys/ufs/ffs/ffs_rawread.c 1.95 +9 -9 src/sys/ufs/ffs/ffs_snapshot.c 1.168 +9 -17 src/sys/ufs/ffs/ffs_softdep.c 1.273 +1 -2 src/sys/ufs/ffs/ffs_vfsops.c 1.150 +12 -10 src/sys/ufs/ffs/ffs_vnops.c