From owner-svn-src-all@freebsd.org Sun Aug 14 05:52:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32830BB95F2; Sun, 14 Aug 2016 05:52:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04BF2195A; Sun, 14 Aug 2016 05:52:01 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id 38so57651313iol.0; Sat, 13 Aug 2016 22:52:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=ZXGSn10+pCzoSv4vmJZ5WZaFTrNb1FE/od16kTktGCQ=; b=O5/W+UEQd0HqOik2hqOiBb1j1SGEI9Rc4fEzQG9f4JjEkdXSNcQ0+taHNs4XA6pD+h ZZNJkWWRiSIckUE88NZjLe5yYAjg/rTLNXWVmBWc22WN8Vg9ZxWyOdUbMPRQY6NmeUvp QzISdLKChXcS03mSiDnvs5/lS5KvgrU9HR2CL/Ipfw4ya3CRSNBAhf/rklKjlHBTCLHl omyF14pD8CnVUIMUzHjG6xvGWkUvEUkJ/OIsSa5ENymR41Zjo5tS014tXLFwysIvVGBH 4FLcVvQPxQhd7HbVAtLUwctBtbZnbQ5RvwPw8p2G1Dzl7avppaxAn0HuX3SicbMSxsVa eBGQ== X-Gm-Message-State: AEkoout/DPZxuYeYksCWntvAPQ6M/VgfMArDQmE7tVStgq3fYpAFDeDUVye5IK77swgwRg== X-Received: by 10.107.195.14 with SMTP id t14mr29928472iof.175.1471153920495; Sat, 13 Aug 2016 22:52:00 -0700 (PDT) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com. [209.85.214.41]) by smtp.gmail.com with ESMTPSA id h67sm7110878ioe.40.2016.08.13.22.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Aug 2016 22:52:00 -0700 (PDT) Received: by mail-it0-f41.google.com with SMTP id c13so6100407ith.1; Sat, 13 Aug 2016 22:52:00 -0700 (PDT) X-Received: by 10.36.227.130 with SMTP id d124mr6798285ith.97.1471153919950; Sat, 13 Aug 2016 22:51:59 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sat, 13 Aug 2016 22:51:59 -0700 (PDT) In-Reply-To: References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> From: Conrad Meyer Date: Sat, 13 Aug 2016 22:51:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf To: Juli Mallett Cc: Glen Barber , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 05:52:02 -0000 On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett wrote: > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: >> Quoting the original request to remove this, which I tend to agree: >> >> -------------------------- begin quoted text --------------------------- >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff >> -x-p') to include function names at the top of each hunk. The problem >> is that diff gets it wrong more often than not, especially (but not >> only) when functions are added or renamed, or outside a funciton, or in >> headers, or in code that makes heavy use of macros, or in files that >> aren't C-like source code: shell scripts, man pages, Makefiles... All >> it really does is clutter up the patch and mislead the reader. >> --------------------------- end quoted text ---------------------------- > > :( > > I'm deeply skeptical that the described conditions add up to "more > often than not," and that tangible harm is done in those cases, > outweighing benefit added in the other, ostensibly rarer, case > (changes in ordinary C source files, which are actually fairly > abundant in FreeBSD.) Exactly. Yes, it gets it wrong sometimes. But not enough to make it more harmful than beneficial. Best, Conrad