From owner-svn-src-head@FreeBSD.ORG Tue Jun 5 12:48:51 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5160810656A4; Tue, 5 Jun 2012 12:48:51 +0000 (UTC) (envelope-from ache@vniz.net) Received: from vniz.net (vniz.net [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 9D5EC8FC1D; Tue, 5 Jun 2012 12:48:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vniz.net (8.14.5/8.14.5) with ESMTP id q55CmmN2013623; Tue, 5 Jun 2012 16:48:49 +0400 (MSK) (envelope-from ache@vniz.net) Received: (from ache@localhost) by localhost (8.14.5/8.14.5/Submit) id q55Cmm7G013622; Tue, 5 Jun 2012 16:48:48 +0400 (MSK) (envelope-from ache) Date: Tue, 5 Jun 2012 16:48:47 +0400 From: Andrey Chernov To: Konstantin Belousov Message-ID: <20120605124847.GB13306@vniz.net> Mail-Followup-To: Andrey Chernov , Konstantin Belousov , Dimitry Andric , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <201206042134.q54LYoVJ067685@svn.freebsd.org> <4FCDBE69.6080906@FreeBSD.org> <20120605083553.GH85127@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Content-Disposition: inline In-Reply-To: <20120605083553.GH85127@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Dimitry Andric Subject: Re: svn commit: r236582 - head/lib/libc/stdlib X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2012 12:48:51 -0000 --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 05, 2012 at 11:35:53AM +0300, Konstantin Belousov wrote: > Not to mention that the patch was committed to _our_ implementation of > libc, which uses _our_ free, and not some abstract free(3). Our free chan= ging > errno means that process state is so messed that worrying about realpath(= 3) > correctness is beyond any expectations. We can't stay with "our free" concept but with "some abstract free"=20 instead. The code must be portable and even "our free" can be replaced in= =20 the future. About errno changing, look at "our free" code pass, potential candidates=20 (as Garrett mentions) are utrace, assert, idalloc - I don't look deep to=20 say for sure. But it does not really matter because the whole "our free"=20 concept is flawed. > I already described my POV to ache, but it seems that nobody listens. It = just > a season, it seems. You deside to not answer to the free() discussion which follows your=20 initial commit, which means either you agree with change or you are not=20 interested. It looks strange that you just consider to answer now and keep= =20 silence at the time of discussion. --=20 http://ache.vniz.net/ --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/OAC8ACgkQVg5YK5ZEdN2BOwCgqT9ce0JL6k9QvfXN6DjGP87x xFEAnRZQAuX2VFJsrT9WzRGguCHO9d2E =uKtO -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--