From owner-freebsd-ports@FreeBSD.ORG Wed Jul 23 19:41:00 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58263106567B; Wed, 23 Jul 2008 19:41:00 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao101.cox.net (eastrmmtao101.cox.net [68.230.240.7]) by mx1.freebsd.org (Postfix) with ESMTP id C4B568FC1A; Wed, 23 Jul 2008 19:40:59 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo03.cox.net ([68.1.16.126]) by eastrmmtao101.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20080723194100.SNCK11636.eastrmmtao101.cox.net@eastrmimpo03.cox.net>; Wed, 23 Jul 2008 15:41:00 -0400 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo03.cox.net with bizsmtp id tXgy1Z0074iy4EG02Xgyaw; Wed, 23 Jul 2008 15:40:59 -0400 Date: Wed, 23 Jul 2008 14:40:57 -0500 To: "Philip M. Gollucci" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <20080723151212.18dfb88d@it.buh.tecnik93.com> <48874AB6.6080604@p6m7g8.com> Content-Transfer-Encoding: 7bit Message-ID: In-Reply-To: <48874AB6.6080604@p6m7g8.com> User-Agent: Opera Mail/9.51 (Linux) Cc: Olafur Osvaldsson , araujo@freebsd.org, ports@freebsd.org, pgollucci@freebsd.org, Ion-Mihai Tetcu , Florent Thoumie Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 19:41:00 -0000 On Wed, 23 Jul 2008 10:13:58 -0500, Philip M. Gollucci wrote: > Florent Thoumie wrote: >> On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu >> wrote: >>> On Wed, 23 Jul 2008 13:08:03 +0100 >>> "Florent Thoumie" wrote: >>> >>>> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson >>>> wrote: >>>>> This is something the PR responsible introduced in his original >>>>> patch... >>>> It's still present in your version. Anyway, I'm not blaming anyone, >>>> just pointing out what I think is a mistake. >>> So this is not for the user but for the port? >>> >>> I'll do a swap on the tree for it, because I'm sure there are more >>> ports doing something like: >>> .ifndef(NO_INSTALL_MANPAGES) >>> ...... >>> .endif > I was talking to itectu@ about this, and figured it would be better in > Mk/bsd.port.mk. > > >> The general rule of thumb is: if it doesn't begin with WITH_ or >> WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for >> ports using imake that don't understand the install.man target. > /me thought that was the USE_ vs WITH(OUT)?_ difference. > > NO* is supposed to be user settable right ? While I am here, have you gotten my email about scons? http://lists.freebsd.org/pipermail/cvs-ports/2008-July/153324.html ---------------------------------------------- # pkg_info -IX scons scons-0.98.5 A build tool alternative to make # ls /usr/local/man/man1/ | grep scons scons-time.1.gz scons.1.gz sconsign.1.gz # pkg_delete -f scons-0.98.5 # ls /usr/local/man/man1/ | grep scons [...empty...] # cd /usr/ports/devel/scons # grep NO Makefile .if !defined (NO_INSTALL_MANPAGES) # make NO_INSTALL_MANPAGES=yes install [...] Installed SCons scripts into /usr/local/bin Installed SCons man pages into /usr/local/man/man1 ===> Registering installation for scons-0.98.5 # ls /usr/local/man/man1/ | grep scons scons-time.1 scons.1 sconsign.1 # pkg_delete -f scons-0.98.5 # ls /usr/local/man/man1/ | grep scons scons-time.1 scons.1 sconsign.1 ---------------------------------------------- The scons plist is broke with NO_INSTALL_MANPAGES. Cheers, Mezz >> Now of course there are exceptions (usually for no good reason IMHO). >> The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to >> WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do >> the work. > Heh, maybe, I kind of feel like it will get reject as a style(9) change. > > I'm all for it though, not saying I'm going to do it though. -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org