From owner-freebsd-current@FreeBSD.ORG  Fri Jan 18 13:49:56 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D0DD7674;
 Fri, 18 Jan 2013 13:49:56 +0000 (UTC) (envelope-from satan@ukr.net)
Received: from hell.ukr.net (hell.ukr.net [212.42.67.68])
 by mx1.freebsd.org (Postfix) with ESMTP id 2064E91E;
 Fri, 18 Jan 2013 13:49:56 +0000 (UTC)
Received: from satan by hell.ukr.net with local ID 1TwCKQ-00023U-JL
 ; Fri, 18 Jan 2013 15:49:54 +0200
Date: Fri, 18 Jan 2013 15:49:54 +0200
From: Vitalij Satanivskij <satan@ukr.net>
To: Vitalij Satanivskij <satan@ukr.net>
Subject: Re: panic after r244584
Message-ID: <20130118134954.GA7848@hell.ukr.net>
References: <20130118073600.GA70874@hell.ukr.net>
 <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org>
 <20130118113934.GA60441@hell.ukr.net>
 <50F9357F.8040109@FreeBSD.org>
 <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi>
 <20130118133415.GA7189@hell.ukr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130118133415.GA7189@hell.ukr.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Jaakko Heinonen <jh@FreeBSD.org>, Alexander Motin <mav@FreeBSD.org>,
 Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-current@FreeBSD.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2013 13:49:56 -0000


May be just do sanitizing for elmpriv->descr?

something like change whitespace to "_" or just delete it?


Vitalij Satanivskij wrote:
VS> Jaakko Heinonen wrote:
VS> JH> On 2013-01-18, Alexander Motin wrote:
VS> JH> > > AM> > V>  panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7)
VS> JH> 
VS> JH> > > AM> The panic is triggered by the check added by the recent r244584 change.
VS> JH> > > AM> The space in device name came from the enclosure device, and I guess it
VS> JH> > > AM> may be quite often situation. Using human readable name supposed to help
VS> JH> > > AM> system administrators, but with spaces banned that may be a problem.
VS> JH> > > 
VS> JH> > > That's was not created by human, it was generated (I think so) by system. 
VS> JH> > 
VS> JH> > These strings are flashed into enclosure firmware by manufacturer.
VS> JH> 
VS> JH> You can't rely on that any string can be safely used as a device name
VS> JH> even if spaces were allowed. Consider for example duplicate names and
VS> JH> "../".
VS> JH> 
VS> JH> Where these names are generated? The original report didn't contain a
VS> JH> backtrace.
VS> 
VS> Yes. No backtrace, because of switching off all debuging in kernel. 
VS> 
VS> For now I can't use that's server for testing, but there are another servers waiting for upgrade.
VS> 
VS> I will try to reproduce problem with  kernel debuger enabled.
VS> 
VS> 
VS> _______________________________________________
VS> freebsd-current@freebsd.org mailing list
VS> http://lists.freebsd.org/mailman/listinfo/freebsd-current
VS> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"