From owner-freebsd-hackers@FreeBSD.ORG Mon May 23 19:25:51 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E2D41065675; Mon, 23 May 2011 19:25:51 +0000 (UTC) (envelope-from aboyer@averesystems.com) Received: from zimbra.averesystems.com (75-149-8-245-Pennsylvania.hfc.comcastbusiness.net [75.149.8.245]) by mx1.freebsd.org (Postfix) with ESMTP id ED0148FC1B; Mon, 23 May 2011 19:25:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zimbra.averesystems.com (Postfix) with ESMTP id 92B1C446001; Mon, 23 May 2011 15:09:20 -0400 (EDT) X-Virus-Scanned: amavisd-new at averesystems.com Received: from zimbra.averesystems.com ([127.0.0.1]) by localhost (zimbra.averesystems.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n+7VI2V7Sohu; Mon, 23 May 2011 15:09:19 -0400 (EDT) Received: from riven.arriad.com (fw.arriad.com [10.0.0.16]) by zimbra.averesystems.com (Postfix) with ESMTPSA id 0F0E38BC001; Mon, 23 May 2011 15:09:19 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1084) From: Andrew Boyer In-Reply-To: <201105231032.20084.jhb@freebsd.org> Date: Mon, 23 May 2011 15:08:05 -0400 Message-Id: References: <4DDA6B95.3090704@soeberg.net> <201105231032.20084.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: jfv@gmail.com, freebsd-hackers@freebsd.org, philip-freebsd1@soeberg.net Subject: Re: device_detach() on a device used by ixgbe driver (FreeBSD 7-STABLE through to 9-CURRENT) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2011 19:25:51 -0000 On May 23, 2011, at 10:32 AM, John Baldwin wrote: > On Monday, May 23, 2011 10:13:41 am Philip Soeberg wrote: >> I would also expect the ixgbe.c driver to do a quick = resource_disabled()=20 >> in it's attach() function, so that we can disable specific adapters=20= >> through kenv hint.ix.0.disabled=3D1.. >=20 > That is not universally supported (i.e. it's not a part of new-bus=20 > specifically). For buses that support hinted devices, they do all = generally=20 > support being able to disable a hinted device, but disabling = bus-enumerated=20 > devices is not generally supported. >=20 FYI, I submitted a patch to Jack to add this in all of the e1000/ixgbe = drivers. Setting a disabled=3D"1" hint causes the attach to fail with = ENXIO. I don't know if it's 'correct' or not but it serves a purpose in = our testing and I thought it would be useful for others. -Andrew -------------------------------------------------- Andrew Boyer aboyer@averesystems.com