From owner-svn-src-head@FreeBSD.ORG Tue May 18 23:20:45 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40AEA1065670; Tue, 18 May 2010 23:20:45 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pz0-f181.google.com (mail-pz0-f181.google.com [209.85.222.181]) by mx1.freebsd.org (Postfix) with ESMTP id E62D68FC18; Tue, 18 May 2010 23:20:44 +0000 (UTC) Received: by pzk11 with SMTP id 11so4360869pzk.28 for ; Tue, 18 May 2010 16:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=Nlena592uBNoEf6l6RE2XZNOGV59xHMiJHAq9gxn3Mo=; b=UlHeYxbWjwklZ3zo+b93GJgeluEhyDU2FD0k/DMz+NHWO62fdYwOnh5HRVtULdow1+ TTotmAb0E0fWBRqoNML+WTNJ1OgGaRJiBvj/Dr0aOIwAYf7xgp/MMo0DB9I3FTBC6vaH GAjoWCqE9MyzBCnPt+UcXmBD1hMFRpkv1F40o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=hvbZYyECmUflbgrl2l72bC3CnRI7iNjDUepxdF+kLcFKwYRZUM/tp4AR+vte/rTOcs QU9N3tEJjIJQnWmVsQj83gtVlYn+be954zYh63yVT6JEQLV0xYQpXSt6BBFafGqAOPwg k4RGpJXug+aDbvSMhX0Vh7A4nOV74hWngIpGY= Received: by 10.141.3.14 with SMTP id f14mr5649895rvi.98.1274224844339; Tue, 18 May 2010 16:20:44 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id h11sm5584960rvm.9.2010.05.18.16.20.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 18 May 2010 16:20:43 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 18 May 2010 16:19:36 -0700 From: Pyun YongHyeon Date: Tue, 18 May 2010 16:19:36 -0700 To: "Bjoern A. Zeeb" Message-ID: <20100518231936.GH5968@michelle.cdnetworks.com> References: <201005101714.o4AHEFuu015079@svn.freebsd.org> <20100518032628.S23815@maildrop.int.zabbadoz.net> <20100518171315.GA5968@michelle.cdnetworks.com> <20100518224555.G23815@maildrop.int.zabbadoz.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100518224555.G23815@maildrop.int.zabbadoz.net> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon Subject: Re: svn commit: r207851 - head/sys/dev/sge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 23:20:45 -0000 On Tue, May 18, 2010 at 10:53:27PM +0000, Bjoern A. Zeeb wrote: > On Tue, 18 May 2010, Pyun YongHyeon wrote: > > >On Tue, May 18, 2010 at 03:27:33AM +0000, Bjoern A. Zeeb wrote: > >>On Mon, 10 May 2010, Pyun YongHyeon wrote: > >> > >>>Author: yongari > >>>Date: Mon May 10 17:14:14 2010 > >>>New Revision: 207851 > >>>URL: http://svn.freebsd.org/changeset/base/207851 > >>> > >>>Log: > >>>Implement TSO and TSO over VLAN. Increase number of allowed > >>>fragmentation of mbuf chain to 32 from 16 because TSO can send 64KB > >>>sized packet which in turn requires long list of mbuf chain. Due to > >>>lack of documentation, I'm not sure whether driver have to pull up > >>>ethernet/IP/TCP header with options to make controller work but > >>>driver have to parse TCP header to update pseudo TCP checksum > >>>anyway. The controller expects pseudo TCP checksum computed by > >>>upper stack and the checksum should follow the MS NDIS > >>>specification to make TSO work. > >>> > >>>Tested by: xclin cs dot nctu dot edu dot tw > > >> > >>This brings in INET as a dependency for the driver and fails on my > >> nooptions INET > >> nooptions INET6 > >>kernels (in_pseudo()). > >> > > > >AFAIK sge(4) is not the only driver that has INET dependency. I > >think we need IPv6 offloading framework(checksum offloading, TSO4 > > There is no checksum on IPv6. > Yes, but controllers that computes only partial checksum for received frames require parsing IPv4/IPv6 header to support checksum offloading. If we have good framework we can avoid duplicated code as well as INET/INET6 dependency. > >and TSO6) before removing INET dependency in various drivers. > >Most recent ethernet controllers support IPv6 offloading and > >FreeBSD still lacks these nice features. > > This is true, but we should (still) fix this and work on a better > solution. You may remember that I tried to get this discussion > started twice during the last 12 months. First time after I added > the inet depency in sys/conf/files for all the other drivers that > have the same problem(s). > > I will be very happy to chat with you and np@ and maybe tuexen@ for > SCTP and Drew and Jack again to get this all sorted out. > I'm also happy to go that direction. But it wouldn't be for 8.1-RELEASE, right? > /bz > > -- > Bjoern A. Zeeb (from 21) Micky Rosa: > But as we've all said, this game is about the past and the future, > and tonight we forget about the past. We just focus on the future.