From owner-freebsd-bugs@FreeBSD.ORG  Tue Sep  2 01:00:35 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AE71216A4BF
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Sep 2003 01:00:35 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7B39C43FCB
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  2 Sep 2003 01:00:34 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h8280YUp080053
	for <freebsd-bugs@freefall.freebsd.org>;
	Tue, 2 Sep 2003 01:00:34 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h8280Xhs080048;
	Tue, 2 Sep 2003 01:00:33 -0700 (PDT)
Date: Tue, 2 Sep 2003 01:00:33 -0700 (PDT)
Message-Id: <200309020800.h8280Xhs080048@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Jason Young" <jyoung8607@hotmail.com>
X-Mailman-Approved-At: Tue, 02 Sep 2003 05:07:46 -0700
Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Jason Young <jyoung8607@hotmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Sep 2003 08:00:35 -0000

The following reply was made to PR bin/46672; it has been noted by GNATS.

From: "Jason Young" <jyoung8607@hotmail.com>
To: freebsd-gnats-submit@FreeBSD.org, swear@attbi.com
Cc:  
Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning
Date: Tue, 02 Sep 2003 02:58:54 -0500

 A better patch: improve error handling, and update documentation.
 
 *** main.c      Tue Sep  2 02:48:03 2003
 --- main.c.orig Tue Sep  2 01:26:49 2003
 ***************
 *** 311,330 ****
         }
         spcl.c_dev[NAMELEN-1]='\0';
         spcl.c_filesys[NAMELEN-1]='\0';
 
         if ((mntpt = getmntpt(disk, &mntflags)) != 0) {
 !               if (mntflags & MNT_RDONLY) {
 !                       if(snapdump == 1) {
 !                               msg("WARNING: %s\n",
 !                                   "-L ignored for read-only filesystem.");
 !                               snapdump = 0;
 !                       }
 !               }
 !               else if (snapdump == 0) {
                         msg("WARNING: %s\n",
 !                           "should use -L when dumping live r/w 
 filesystems!");
                 } else {
                         struct ufs_args args;
                         char snapname[BUFSIZ];
 
                         snprintf(snapname, sizeof snapname, 
 "%s/.dump_snapshot",
 --- 311,323 ----
         }
         spcl.c_dev[NAMELEN-1]='\0';
         spcl.c_filesys[NAMELEN-1]='\0';
 
         if ((mntpt = getmntpt(disk, &mntflags)) != 0) {
 !               if (snapdump == 0) {
                         msg("WARNING: %s\n",
 !                           "should use -L when dumping live filesystems!");
                 } else {
                         struct ufs_args args;
                         char snapname[BUFSIZ];
 
                         snprintf(snapname, sizeof snapname, 
 "%s/.dump_snapshot",
 fury#
 
 
 *** dump.8.orig Tue Sep  2 02:12:53 2003
 --- dump.8      Tue Sep  2 02:54:39 2003
 ***************
 *** 211,220 ****
 --- 211,222 ----
   To obtain a consistent dump image,
   .Nm
   takes a snapshot of the file system and
   then does a dump of the snapshot.
   The snapshot is removed when the dump is complete.
 + This option is disregarded for unmounted or read-only
 + mounted filesystems.
   .It Fl n
   Whenever
   .Nm
   requires operator attention,
   notify all operators in the group
 
 _________________________________________________________________
 MSN 8: Get 6 months for $9.95/month. http://join.msn.com/?page=dept/dialup