Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Sep 2020 02:31:29 +0000
From:      Rick Macklem <rmacklem@uoguelph.ca>
To:        "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
Subject:   review of mountd.c change
Message-ID:  <YTBPR01MB39667D6CBE541525B2F9728DDD3B0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM>

next in thread | raw e-mail | index | archive | help
Hi,=0A=
=0A=
I just put a patch up in phabricator (D26521) which avoids always=0A=
malloc()'ng a large MAX_NGROUPS sized groups list by having a=0A=
small one in the structure and then only malloc()'ng when a large=0A=
groups list is needed.=0A=
=0A=
I've listed kib@ and freqlabs@ as reviewers, but anyone else is=0A=
welcome to review it.=0A=
=0A=
The review is probably about the technique I used.=0A=
(Alternately, the could just always malloc() the groups array the=0A=
 correct size instead of using the SMALLNGROUPS one or malloc()'ng.)=0A=
=0A=
Thanks in advance to anyone that reviews it, rick=0A=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTBPR01MB39667D6CBE541525B2F9728DDD3B0>