From owner-freebsd-current@freebsd.org Tue Sep 22 02:31:34 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CD99426E18 for ; Tue, 22 Sep 2020 02:31:34 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670084.outbound.protection.outlook.com [40.107.67.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BwQKx0k06z4Lmm for ; Tue, 22 Sep 2020 02:31:32 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bxs2xg3DKz2eQNNTBHw290XSzYyaR7iNS6k90HbmQM5/Ol4iDxCCDWXOfeJWgZkJ/jWFvH+3wGqm/1FXePC3SDE5U44NzbL+aMXWSQz8HPIZWNatqAUE//0XdX4tKk3x/uF666D8jXdSNaNRKCuaegfozJ/D8hOM877DTY/u5d/MN6ewuqDhg9At3lP8RIomvrCzHAzZtPrY8XLMdfPQOHUxUfJtd1GbdHLxwEivMMIZ+28dc4ew2i6WEFzQ6jnwrdJJHIfFOurcWHLnddE7x5UpDZGbD80UXZC/oLZ+ZFGtNRzwGl2g8wW5OxkG6aMO1YnbExh5wsEsb5IxMik7Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=isNBfjZHj8ZqpRY3lr9RvToaoLg+zVBGBGmT1wpXUnA=; b=O3ajP2SE2FyFscgAY9xlSLcwwoTegbgcDN/Pbcke8vnScTfrCQw37fDFtIeq8f/fZcFAFQSBOG6n25Kft091oPjafaWEZyoBEcOGnZN9GWAUwk9+VGzuZ3HknfICTuwSnD/exCBC0JP+YLbo7Blp1EhjtjjQUh7ZrpWwe1HTtDgJB52r2++yJfhZxQJZ5cN+OOhZNmwlGtbqsmtjei9MNS/1kyBtWPLGtBq1qUswvgC4v/yFV2MdZXDkhTysT58CRk7Escsm6+GTgPrf5jDNEsxSptPcPzRuQm8Dlo5xaSc2gmwpUhrRlyZsd6FPW3+Kcy1QzmNhtzExjBsCJrhSFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:24::27) by YT1PR01MB2697.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Tue, 22 Sep 2020 02:31:30 +0000 Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20]) by YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20%6]) with mapi id 15.20.3391.024; Tue, 22 Sep 2020 02:31:29 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: review of mountd.c change Thread-Topic: review of mountd.c change Thread-Index: AQHWkIf27YuiSKWc+0CU83aib72v2w== Date: Tue, 22 Sep 2020 02:31:29 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b517b68-e791-4002-c069-08d85e9f9d02 x-ms-traffictypediagnostic: YT1PR01MB2697: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HP584GE51PnoJPusfu40HmZAZJVcbmCEFWcW08n3IFPmq8QhVuriXZ5czPP8feHy36zxIKJXQ2/daFqeNOrh+n9pPXrupd4aZIMvHfhrLPPCIOL0GjbCbxWWxaZ1QTuMsAZta0vwI4+Bj6NlCXIvKie/5zUQH6fUydSBP2gQb5IWHGzXOxAKIs8HFyNI6hOg6q4frlTXtbkTCE9rmohPcYO462uThXK14zOiVMyU6bFyDd76O+ieANk7aMpacv6fv3Y0zV2DxuRyD3ISm2g6L8GrN3KtYQGMoMR8T1oJeLCAyyJSWbmbR8ZF8a/w2rI9zuvMSgEsLTf9dtmMzb+OgP6f+cmg/qKjUIUVmv1zWNGbn38KgViu5bbKlb/Z/abb x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(39860400002)(366004)(136003)(346002)(376002)(396003)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(186003)(91956017)(8936002)(52536014)(4744005)(8676002)(786003)(5660300002)(316002)(9686003)(71200400001)(6506007)(7696005)(55016002)(2906002)(33656002)(86362001)(478600001)(6916009)(3480700007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: N0Qq9vcqnLh40eGdyyfO1J73NXnSr4dcwJgxlXVuHRVLgjWyfEZ7KYMPhd/agEDNYJOeTUm0PCmdmyW9e/KAF2y6F9Waq+1NQdbiCRmeB2hEm4OjeQNCZ3PccBsV1aDDss8YkIRfT8TQxKyRC8kBBgW99RPep9EJZcamN7Nj2QBroEOLYSoVNKosWIbUwcrwRUL81SRb/tF6/O/YQ/60A9NWtXXpFbW2agrkVhm34Y7HIq9qWNWW9qYSs1eVnOeDvJLxPmd/qmQfUx/s+yadNqVXeTQgcUAiMBErnEBCHmfmV1ZI8Qbii2zRqOeYqCcbL2PCxoMwTW1w7+6BDc/gpKfKN9Vz3a0Bkr1PpiItVaShmIwIU2T/LR9ZNQLIS9qkz+ibOW7XZ9rUnk8ORAXxzMYxkoYd2WKSbL11ltjdXX/kSrEWn3VS86aFkTdaac4ulpfqVGjiN/mhnALtY/k5Ti51l0r/Zzle9iPbiKwSP6pKZ0IeXyVqrv/SDHAikBEejAdnhMUmxzOSJfGJiUorz4bcRRqw4JWMrBzHuAD4rtjxMIIrcos3jnIozYqZjvUdeaLG6kyXt0VGnP0dVfjmLd45F2WgkS1WbHEuTwJOlb2RLU8ZquvEk/ZH7gNvrVEeqRIOx0FShLTYiWyAtGqlcNWqdfOubEMaTi8XCfR8J9Eo6ttiNX+pK6lafirpeTghhverdV/kB/jLbv0owSIhXg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2b517b68-e791-4002-c069-08d85e9f9d02 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 02:31:29.9199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0F7Usq7aqcZSmldcNXr/cYK5TLT6AqSIMB+oUP8BP1Zjq4yF00qfBlvNHKixdOuzyR0kd2jbiQftZnfINqyb0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB2697 X-Rspamd-Queue-Id: 4BwQKx0k06z4Lmm X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.01 / 15.00]; NEURAL_HAM_MEDIUM(-0.98)[-0.979]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FREEFALL_USER(0.00)[rmacklem]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.03)[-1.032]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[uoguelph.ca:+]; DMARC_POLICY_ALLOW(-0.50)[uoguelph.ca,none]; RCVD_IN_DNSWL_NONE(0.00)[40.107.67.84:from]; NEURAL_HAM_SHORT(-1.00)[-0.997]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MAILMAN_DEST(0.00)[freebsd-current]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.67.84:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 02:31:34 -0000 Hi,=0A= =0A= I just put a patch up in phabricator (D26521) which avoids always=0A= malloc()'ng a large MAX_NGROUPS sized groups list by having a=0A= small one in the structure and then only malloc()'ng when a large=0A= groups list is needed.=0A= =0A= I've listed kib@ and freqlabs@ as reviewers, but anyone else is=0A= welcome to review it.=0A= =0A= The review is probably about the technique I used.=0A= (Alternately, the could just always malloc() the groups array the=0A= correct size instead of using the SMALLNGROUPS one or malloc()'ng.)=0A= =0A= Thanks in advance to anyone that reviews it, rick=0A=