From nobody Sat Aug 17 13:41:30 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WmKlQ5SvYz5T3ln; Sat, 17 Aug 2024 13:41:38 +0000 (UTC) (envelope-from nicola.stanislao.vitale@gmail.com) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WmKlQ3lWtz4fkF; Sat, 17 Aug 2024 13:41:38 +0000 (UTC) (envelope-from nicola.stanislao.vitale@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42819654737so20334885e9.1; Sat, 17 Aug 2024 06:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723902092; x=1724506892; darn=freebsd.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=jo3seQCCzP3U8iS4PLFZs1pzYatgRyNyT8BgjjBKd+c=; b=Rc7uKDU853B0haNl4GPwCka/P6RTEY+OU/gxt7JmlX+MonMedV7/Sb3cZe2AkUiEkH IjLPQ4M3m/a741e1GctmKv/A/tEZ/Ldtuq60//Pt+7t0cic//wJMY56nzi7beVf7t+oG 85ypC4yd/CHP07R8iCmQcD2PvuJCMI8fe/0twdOu9WvqyPpl/6bfAJlrnGVt3VV2qIdu UX57sINXVPaMcUQDfF7MuK8GdpIufj/Idw7k1Ntrqyx+F1V9O7G5dXsB+49+wr4yPy61 LD2IoTI39sK/QmGwwhapY6/3qC6WoMYUqBhKRqVLuy5StKF0o8W5qjIXd0aAzjDv2Rx9 AFPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723902092; x=1724506892; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jo3seQCCzP3U8iS4PLFZs1pzYatgRyNyT8BgjjBKd+c=; b=p5DOtWyYUBk4U4inoLlA8IzBo6tjR3ibY9YJaLmhQ345vgQTd5zcbsSH4mgVgWHTsz 7q1JLPZXoUVeIlE2GB92AM/lH2gTeu6B1hkSjq8Ng5P9l8qyHbu7vFeClUwgyp0H7UZq uK07F83pBmFMSPpq83+jxqA8hVmxOrNenYjOble93Zjf9ZUMRwkBwbGJ64FheRhHRDyv e7JfwBeOb4Ktpjmsgf5A5Us8y8QY79CcjsF0dyp+LkAWtFmXmt2BuqX6tP6kgBYE7pGT e7KUx8JcwkRvUg7lVgbB5zClZOMj8Cy8BuJKH0RvQs4q9d4gPTsppDBG53MG0TE0qZVf EVCw== X-Forwarded-Encrypted: i=1; AJvYcCVtsLTyTEC5pjVcvjevGLIIvg/+o/mEZs/pWYtCpJvkwCi55JFq3Xm0eKqpD9ZWsOnKbNvYbSUlNyDOfNiFVSS1Kz90r54AQhgQsAEOnQ+ztdADfk9/2DDBgln1rfVUa56trCVmMGRTKjIWEoPTmdULZx/BkLMkOluFshrxgONDSOuA7PlHoxyh X-Gm-Message-State: AOJu0YyL6BsdObigs1FoTBL3CRYqR0sGc8flddZsx/k4gzNmkmepD2Jd 5jYnytbiWr3yEkB0GML0H7IDJtC+tjtgwI/q3bHATfk/tgkcqLr9Ucndp/+5 X-Google-Smtp-Source: AGHT+IEdIvnnR/z0slvSOFtLw3/Mv88mJxUQYswzBu57Tlg5EQ5gdsMV11wRF9BGolDCrTbNVxg6Cw== X-Received: by 2002:a05:600c:3109:b0:426:63b4:73b0 with SMTP id 5b1f17b1804b1-429ed7dba8dmr38376725e9.34.1723902091799; Sat, 17 Aug 2024 06:41:31 -0700 (PDT) Received: from [192.168.1.232] ([151.30.6.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed6585d1sm50154345e9.22.2024.08.17.06.41.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Aug 2024 06:41:31 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------5LHIk79tUfiAurjaWEGNB1UE" Message-ID: <7ad037a5-a92c-455e-b54c-9287e4fe5749@gmail.com> Date: Sat, 17 Aug 2024 15:41:30 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: d191d48e545e - main - x11/kitty: Fix pkg-plist when DOCS option is off To: Gleb Popov , Nicola Vitale Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202408170839.47H8d1f6010111@gitrepo.freebsd.org> Content-Language: en-US From: Nicola Vitale Autocrypt: addr=nicola.stanislao.vitale@gmail.com; keydata= xjMEZRmQWRYJKwYBBAHaRw8BAQdANAXgNkczaPIkt0AMYwwF/TYlBfnHJ4DnzR1HPUyIsJTN O05pY29sYSBTdGFuaXNsYW8gVml0YWxlIDxuaWNvbGEuc3RhbmlzbGFvLnZpdGFsZUBnbWFp bC5jb20+wpkEExYKAEEWIQSO9VB2xi2YgOvTy3SsWdrYpgsPSQUCZRmQWQIbAwUJBGXhAAUL CQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCRCsWdrYpgsPSWLnAQCphQ+Xs7dep7DsCvRl ZvtnUV6t297DqTZH5L/O1PAmSgD/T6yJx+9m+cZ6+l5fUR5N3wXxu3Ekes4QLQvAzRIoRQTO OARlGZBZEgorBgEEAZdVAQUBAQdADpdwUsQoWEH8fSkjoUv1rM68FWgRmdj+lek1Bnxrq0ID AQgHwn4EGBYKACYWIQSO9VB2xi2YgOvTy3SsWdrYpgsPSQUCZRmQWQIbDAUJBGXhAAAKCRCs WdrYpgsPSXviAP9/jorsWIqz3Zlo0Hdyj3u6cNaq0td0IaSY7BdMnKT1PgD8Dj4nCECRRNvg M+FdoB2KxeEcINeAb1/QESrqbYMXuw0= In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4WmKlQ3lWtz4fkF This is a multi-part message in MIME format. --------------5LHIk79tUfiAurjaWEGNB1UE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, thanks for the advice, but [1] the option MANPAGES is not present in the Porter's Handbook, and the section 5.12 (Man pages) says only that "manual pages must be placed in pkg-plist along with the rest of the files". This distinction between man pages and other docs is misleading in my opinion. "What are docs?" [2] Furthermore, x11/kitty is not the only one that uses %%PORTDOCS%%/share/man in pkg-plist, and NO_INSTALL_MANPAGES was removed a long time ago. And do you also want to fix all ports that install man pages directly without providing the magic option MANPAGES? And then why not fix all other ports that don't install them even if they are present in the distribution file too? They are essential *documentation*. This would not be a waste of time... [1] I don't remember swearing allegiance to the Porter's Handb...Bible. ;-) [2] https://www.reddit.com/r/freebsd/comments/nc5c5v/whats_the_difference_between_docs_and_manpages/ On 17/08/24 11:07, Gleb Popov wrote: > On Sat, Aug 17, 2024 at 11:39 AM Nicola Vitale wrote: >> +%%PORTDOCS%%share/man/man1/kitty.1.gz >> +%%PORTDOCS%%share/man/man5/kitty.conf.5.gz > Note in "5.17.4. Install Additional Documentation" says [1] > >> The DOCS option only controls additional documentation installed in DOCSDIR. It does not apply to standard man pages and info pages. > So these files are better handled by the MANPAGES option. > > [1]https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation -- -- Nicola Vitale --------------5LHIk79tUfiAurjaWEGNB1UE Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi,

thanks for the advice, but [1] the option MANPAGES is not present in the Porter's Handbook, and the section 5.12 (Man pages) says only that "manual pages must be placed in pkg-plist along with the rest of the files". This distinction between man pages and other docs is misleading in my opinion. "What are docs?" [2]

Furthermore, x11/kitty is not the only one that uses %%PORTDOCS%%/share/man in pkg-plist, and NO_INSTALL_MANPAGES was removed a long time ago.

And do you also want to fix all ports that install man pages directly without providing the magic option MANPAGES?

And then why not fix all other ports that don't install them even if they are present in the distribution file too? They are essential *documentation*.

This would not be a waste of time...

[1] I don't remember swearing allegiance to the Porter's Handb...Bible. ;-)

[2] https://www.reddit.com/r/freebsd/comments/nc5c5v/whats_the_difference_between_docs_and_manpages/

On 17/08/24 11:07, Gleb Popov wrote:

On Sat, Aug 17, 2024 at 11:39 AM Nicola Vitale <nivit@freebsd.org> wrote:

+%%PORTDOCS%%share/man/man1/kitty.1.gz
+%%PORTDOCS%%share/man/man5/kitty.conf.5.gz

Note in "5.17.4. Install Additional Documentation" says [1]


The DOCS option only controls additional documentation installed in DOCSDIR. It does not apply to standard man pages and info pages.

So these files are better handled by the MANPAGES option.

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation

-- 
--
Nicola Vitale
--------------5LHIk79tUfiAurjaWEGNB1UE--