From owner-freebsd-fs@freebsd.org  Tue Apr 11 20:32:16 2017
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C402D3A11B
 for <freebsd-fs@mailman.ysv.freebsd.org>; Tue, 11 Apr 2017 20:32:16 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E1FCCD86;
 Tue, 11 Apr 2017 20:32:15 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (localhost [IPv6:::1])
 by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id v3BKWwBn005429;
 Tue, 11 Apr 2017 13:32:58 -0700 (PDT)
 (envelope-from mckusick@chez.mckusick.com)
Message-Id: <201704112032.v3BKWwBn005429@chez.mckusick.com>
From: Kirk McKusick <mckusick@mckusick.com>
To: Maxim Sobolev <sobomax@freebsd.org>
Subject: Re: mksnap_ffs(8) is not working while chrooted
cc: FreeBSD Filesystems <freebsd-fs@freebsd.org>
In-reply-to: <CAH7qZfu+srbxi9f7xz8X83jq8rNS2NeOsLf_60nYcgxNOXFDbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5427.1491942778.1@chez.mckusick.com>
Date: Tue, 11 Apr 2017 13:32:58 -0700
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Apr 2017 20:32:16 -0000

> From: Maxim Sobolev <sobomax@freebsd.org>
> Date: Tue, 11 Apr 2017 13:22:08 -0700
> Subject: Re: mksnap_ffs(8) is not working while chrooted
> To: Kirk McKusick <mckusick@mckusick.com>
> 
> Kirk, actually it turns out this is not too difficult to work around this
> issue completely in userland. Please see the patch attached, should be
> relatively bulletproof as it actually verifies fsid of whatever it finds
> with the fsid of the target FS. Please let me know if there are any
> objections to include it into the base system.
> 
> Thanks!
> -Maxim

With your change to verify the matching fsid's, I am fine with your
putting this change into the base system.

	Kirk McKusick