Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Feb 2015 10:46:56 +0300
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Craig Rodrigues <rodrigc@FreeBSD.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Nikos Vassiliadis <nvass@gmx.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID:  <20150216074656.GE15484@FreeBSD.org>
In-Reply-To: <CAG=rPVck2VbsDcGxnBv7B3NEQyoqtY2_nHUES_V5T9FyQ1qjiQ@mail.gmail.com>
References:  <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> <CAG=rPVc2YLB-3ZyxDZTxDpkt6R8E_Sf1U%2BWWwKrFB2dxTXGENQ@mail.gmail.com> <20150215190100.GQ15484@FreeBSD.org> <CAG=rPVfK-Qmh7E_%2B-Mmo8kTrDWq=%2B%2ByVCzHNaQ=5pQh7aSaESQ@mail.gmail.com> <CAG=rPVd8VkPLHDQqBZPWmFA93%2BR26qUAwQGT2YUpxYJ8hZFJHA@mail.gmail.com> <20150216012528.GA15484@FreeBSD.org> <CAG=rPVck2VbsDcGxnBv7B3NEQyoqtY2_nHUES_V5T9FyQ1qjiQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 15, 2015 at 11:36:17PM -0800, Craig Rodrigues wrote:
C> On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff <glebius@freebsd.org> wrote:
C> 
C> > On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote:
C> > C> By the way, it would be helpful if you could provide feedback in
C> > C> Phabricator.  When I created those Phabricator reviews, I added
C> > C> you as a reviewer to all of them, so you can't say that you didn't see
C> > C> the patches.
C> > C> You did not provide feedback on any of them:
C> > C>
C> > C> https://reviews.freebsd.org/D1309
C> > C> https://reviews.freebsd.org/D1312
C> > C> https://reviews.freebsd.org/D1313
C> > C> https://reviews.freebsd.org/D1315
C> > C>
C> > C> Please take some time to go and provide feedback in those
C> > C> reviews, so that a better patch can be made that makes you happy.
C> >
C> > Did you address all problems that arised after code was committed?
C> >
C> > Please do, otherwise my review would require me to cut-n-paste from
C> > my own emails.
C> >
C> 
C> Yes, please cut and paste from your e-mails, and put in the reviews.

No, I will not do this. You know right now that you have problems
in the aforementioned phab URLs, and you are asking me to look at
patches at to point them out to you. This is your task, not mine.

Please address all already known problems and update the phab revisions.

C> It's easier to follow in the individual reviews because there are different
C> changes
C> in each review, rather than one big revert, which is what you did.

I'm already starting to repeat myself. I did a big revert, because
the first change wasn't compilable, later changes fixed compilation
failures, but introduced unacceptable bugs. That's why I was forced
to back out all chain.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150216074656.GE15484>