From owner-freebsd-virtualization@FreeBSD.ORG Sun May 17 14:49:51 2009 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CD741065672 for ; Sun, 17 May 2009 14:49:51 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 15DCD8FC1D for ; Sun, 17 May 2009 14:49:51 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 5B51141C690; Sun, 17 May 2009 16:49:50 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id oSqc5DLXpqUZ; Sun, 17 May 2009 16:49:50 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id EFFCE41C678; Sun, 17 May 2009 16:49:49 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 559484448E6; Sun, 17 May 2009 14:49:32 +0000 (UTC) Date: Sun, 17 May 2009 14:49:32 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Sevan / Venture37 In-Reply-To: <4A10222D.8080100@gmail.com> Message-ID: <20090517144647.R72053@maildrop.int.zabbadoz.net> References: <4A06E7B0.10600@gmail.com> <200905110409.04612.zec@icir.org> <4A10222D.8080100@gmail.com> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: FreeBSD virtualization mailing list Subject: Re: Kernel Compiled with options VIMAGE panics on boot X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2009 14:49:51 -0000 On Sun, 17 May 2009, Sevan / Venture37 wrote: Hi, > I've tried to compile a new kernel once again after updating src, this time > it bombs out during the build process. > > http://img33.imageshack.us/img33/6164/img1064.jpg yes, we are aware of that one and the patch is easy and both Marko and I have it but the commit, that introduced this compile time regression for VIMAGE, also introduced a regression for the !VIMAGE && !VIMAGE_GLOBALS case that we are currently trying to indentify. Here's the patch you want to apply (pasted in) to make things compile again. Index: sys/netinet/in.c =================================================================== --- sys/netinet/in.c (revision 192250) +++ sys/netinet/in.c (working copy) @@ -814,6 +814,7 @@ in_ifinit(struct ifnet *ifp, struct in_ifaddr *ia, struct sockaddr_in *sin, int scrub) { + INIT_VNET_NET(ifp->if_vnet); INIT_VNET_INET(ifp->if_vnet); register u_long i = ntohl(sin->sin_addr.s_addr); struct sockaddr_in oldaddr; @@ -1007,6 +1008,7 @@ static int in_scrubprefix(struct in_ifaddr *target) { + INIT_VNET_NET(curvnet); INIT_VNET_INET(curvnet); struct in_ifaddr *ia; struct in_addr prefix, mask, p; /bz -- Bjoern A. Zeeb The greatest risk is not taking one.