Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 May 2025 14:19:32 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: a40e695a5dfe - main - socket_splice tests: Explicitly bind to the loopback address
Message-ID:  <202505261419.54QEJW0w094835@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=a40e695a5dfed63be0998f9523d9840036f3c018

commit a40e695a5dfed63be0998f9523d9840036f3c018
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-05-26 14:13:36 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-05-26 14:13:36 +0000

    socket_splice tests: Explicitly bind to the loopback address
    
    Otherwise, when connecting to the value returned by getsockname(), we
    inadvertently end up connecting to INADDR_ANY, which stopped working
    after commit cd240957d7ba ("netinet: Disallow connections to
    INADDR_ANY").
    
    Fixes:  cd240957d7ba ("netinet: Disallow connections to INADDR_ANY")
---
 tests/sys/kern/socket_splice.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/sys/kern/socket_splice.c b/tests/sys/kern/socket_splice.c
index 3a85ae91ecc7..dfd4cb4f5957 100644
--- a/tests/sys/kern/socket_splice.c
+++ b/tests/sys/kern/socket_splice.c
@@ -84,7 +84,7 @@ tcp_socketpair(int out[2], int domain)
 		memset(&sin, 0, sizeof(sin));
 		sin.sin_family = AF_INET;
 		sin.sin_len = sizeof(sin);
-		sin.sin_addr.s_addr = htonl(INADDR_ANY);
+		sin.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
 		sin.sin_port = htons(0);
 		sinp = (struct sockaddr *)&sin;
 	} else {
@@ -92,7 +92,7 @@ tcp_socketpair(int out[2], int domain)
 		memset(&sin6, 0, sizeof(sin6));
 		sin6.sin6_family = AF_INET6;
 		sin6.sin6_len = sizeof(sin6);
-		sin6.sin6_addr = in6addr_any;
+		sin6.sin6_addr = in6addr_loopback;
 		sin6.sin6_port = htons(0);
 		sinp = (struct sockaddr *)&sin6;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505261419.54QEJW0w094835>